Skip to content

feat: SendGrid email helper #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adeelcentrox wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: SendGrid email helper #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9629e61
feat: add SendGrid email helper
May 6, 2026
a4265c3
fix: read sendgrid creds from env, add types, drop console.log, add e…
May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions src/utils/email-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
interface EmailResult {
accepted: number;
}

export async function sendEmail(
to: string,
subject: string,
body: string,
): Promise<EmailResult> {
const sendgridKey = process.env.SENDGRID_API_KEY;
const fromAddress = process.env.EMAIL_FROM_ADDRESS;
if (!sendgridKey || !fromAddress) {
Copy link
Copy Markdown
Owner Author

@adeelcentrox adeelcentrox May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[major] No runtime validation of the input parameters is performed before passing them to the SendGrid API (e.g., to, subject, or body).

Suggestion: Add validation for parameters (to, subject, body) at the start of the function, rejecting improperly formed or empty values before proceeding.

throw new Error("SENDGRID_API_KEY and EMAIL_FROM_ADDRESS must be set");
}

const response = await fetch("https://api.sendgrid.com/v3/mail/send", {
method: "POST",
Copy link
Copy Markdown
Owner Author

@adeelcentrox adeelcentrox May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[minor] Raw string URL and email type are hardcoded as magic strings: "https://api.sendgrid.com/v3/mail/send", "text/plain".

Suggestion: Move URLs and fixed values to named constants, or, if configurable, into environment variables.

headers: {
Authorization: `Bearer ${sendgridKey}`,
"Content-Type": "application/json",
},
body: JSON.stringify({
personalizations: [{ to: [{ email: to }] }],
from: { email: fromAddress },
subject,
content: [{ type: "text/plain", value: body }],
Copy link
Copy Markdown
Owner Author

@adeelcentrox adeelcentrox May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[major] No error handling is present for the fetch API call. Failures will throw uncaught exceptions.

Suggestion: Wrap the fetch call in try/catch and handle or propagate errors appropriately.

}),
});
if (!response.ok) {
throw new Error(`SendGrid send failed: ${response.status} ${response.statusText}`);
}
Copy link
Copy Markdown
Owner Author

@adeelcentrox adeelcentrox May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[major] The function promises an explicit EmailResult return type, but returns the parsed response.json() object, which is not guaranteed to match the EmailResult interface.

Suggestion: Explicitly shape and check the response JSON to match EmailResult before returning, or map/validate its structure before returning.

return response.json();
}
Loading