Add two new reworked Fusion templates for creating centerpieces#95
Open
ColinCampbell wants to merge 1 commit intoaderusha:mainfrom
Open
Add two new reworked Fusion templates for creating centerpieces#95ColinCampbell wants to merge 1 commit intoaderusha:mainfrom
ColinCampbell wants to merge 1 commit intoaderusha:mainfrom
Conversation
…have corrected measurements for good fit
Author
|
I should mention that I printed a test piece from each of these and verified that the fit the existing sidepieces I have (2x0 Flat Left/Right) and they mount perfectly to the wall board when I was having trouble with the previous template |
Contributor
|
I also noticed this problem. @aderusha can you please merge in this pull request (and mine, too)? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was using the previously available centerpiece template to print some attachments but I noticed the fit between the printed pins and the sidepieces I had printed was really poor. In digging into the Fusion source, I found that a lot of the measurements were slightly off:
9.5mmin length, when they are supposed to be10mm - 0.1mmwith the0.1mmbeing removed for easier fit. A similar issue exists for height at3.5mminstead of4mm - 0.1mmIn taking a look at the more up-to-date FreeCAD source, it had:
This pull request adds two different Fusion templates, one which will generate a centerpiece that has the pin holes in it, allowing you to print the pins separately, along with one that generates the pins into the centerpiece itself. I mostly did the former to copy the approach of the FreeCAD source and then decided that having an updated version of the old template would also be helpful. Let me know if you'd prefer to just have one!
The existing pin-included template had a fillet on the centerpiece but the FreeCAD version didn't. The sidepieces I have printed don't have a rounded edge so a flat edge looks better. I was trying to figure out how to get Fusion to make the fillet configurable but couldn't get it. I figured people could do what I did and just delete the fillet if they don't want it but wanted to see what you thought first.
I've tried to clarify some of the parameters to make them easier to understand. I've attached screenshots of the parameters as well as what is generated for review. Happy to adjust anything.