Skip to content

Improve Najm example against eval audit#4

Closed
adewale wants to merge 1 commit into
pr/tally-eval-auditfrom
pr/najm-eval-audit
Closed

Improve Najm example against eval audit#4
adewale wants to merge 1 commit into
pr/tally-eval-auditfrom
pr/najm-eval-audit

Conversation

@adewale

@adewale adewale commented May 25, 2026

Copy link
Copy Markdown
Owner

Stacked on #3. Review this PR against pr/tally-eval-audit, not main.

What

Improves the Najm example using the eval audit from #2 while preserving the Moroccan fashion/drop direction.

Targeted changes:

  • switches body copy away from overused Inter to Source Sans 3 while keeping Bricolage Grotesque for display
  • removes glassmorphism from the sticky nav and product tag
  • tokenizes raw OKLCH gradients in product/editorial surfaces
  • fixes low-contrast accent-filled badges/buttons detected by the audit
  • removes emoji/star glyphs used as decorative feature markers
  • changes the cart drawer from a modal dialog role to a labelled region, matching its non-focus-trapping drawer behavior
  • fixes skipped footer heading levels
  • adds root overflow-x: clip
  • keeps announcement content visible on mobile instead of hiding it
  • removes rote hover-scale transforms
  • adds disabled-state coverage

Why

Najm was another low-scoring real example in the audit. This PR is the second proof-of-value pass: the eval harness can identify concrete, fixable issues in existing examples without requiring a wholesale redesign.

Audit evidence

Before this PR:

examples/najm/  v1 3.12  v2 3.27
findings: type-overused-font, color-token-discipline, color-ink-on-ink,
visual-glassmorphism, layout-center-everything, layout-arbitrary-spacing,
layout-skipped-heading, motion-hover-scale, interaction-emoji-icon,
interaction-modal-reflex, responsive-overflow-clip,
responsive-feature-amputation, general-state-coverage

After this PR:

examples/najm/  v1 5.00  v2 5.00
findings: —

Testing

node evals/check.mjs
node evals/audit-site.mjs site/examples/najm/index.html

Observed:

PASS v1: 98.5/100   rules 37   fixtures 3
PASS v2: 98.7/100   rules 43   fixtures 5   structure 5.00/5

examples/najm/  v1 5.00  v2 5.00   —

Risk

This touches a visual example, so browser review is still needed. The largest semantic change is the cart drawer role: the drawer was labelled as modal, but the implementation does not trap focus, so role="region" better matches the current behavior.

@adewale

adewale commented Jun 1, 2026

Copy link
Copy Markdown
Owner Author

Superseded by upstream PRs Nutlope#12-Nutlope#14.

@adewale adewale closed this Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant