added functionality for downloading articles from multiple urls and some refactoring#27
Open
ntsvetanov wants to merge 9 commits into
Open
added functionality for downloading articles from multiple urls and some refactoring#27ntsvetanov wants to merge 9 commits into
ntsvetanov wants to merge 9 commits into
Conversation
added 7 commits
January 22, 2022 17:47
Owner
|
@ntsvetanov are you still interested into merging this? If so, i will test it out and review it, Apologies but i did not see the PR and the project is/was kind of stale. I am up for bring it back on track though :) |
Contributor
Author
|
Sure, if you want I can think for more improvements :) |
adimitrova
reviewed
Jan 11, 2024
| else: | ||
| if "url" in config["article"].keys(): | ||
| if from_file: | ||
| self.url = config["article"]["txtPath"] |
Owner
There was a problem hiding this comment.
could we keep snake_case for the keys, please? :)
adimitrova
reviewed
Jan 11, 2024
| def append_keyvalue_to_json_file(file_path, key, value): | ||
| # Modify the original config file with pocket auth code once authenticated, to avoid re-authentication | ||
| with open(file_path, "r") as cfi: | ||
| with open(file_path, "r", encoding="utf-8") as cfi: |
adimitrova
reviewed
Jan 11, 2024
| access_code = None | ||
| #TODO save access code in json file and read it from there | ||
|
|
||
| pocket_client = Pocket(EPUBIFY_KEY, REDIRECT_URL, access_code) |
added 2 commits
January 11, 2024 15:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.