Skip to content

Enable Debian security repo by default#522

Open
funtri-vt wants to merge 6 commits into
ading2210:mainfrom
funtri-vt:add-debian-security-repo-to-apt-sources
Open

Enable Debian security repo by default#522
funtri-vt wants to merge 6 commits into
ading2210:mainfrom
funtri-vt:add-debian-security-repo-to-apt-sources

Conversation

@funtri-vt

Copy link
Copy Markdown

This is a fix for a problem I noticed where the debian security repo isn't enabled by default.
If you think it shouldn't be enabled by default, or if I put the activation of it in the wrong place, please feel free to guide me/close this PR.

add debian security repo
@funtri-vt funtri-vt changed the title Update setup_rootfs.sh Update setup_rootfs.sh to add debian security repo by default Jun 12, 2026
@funtri-vt

funtri-vt commented Jun 12, 2026

Copy link
Copy Markdown
Author

Just realized that Linux-base being upgraded might be a problem. I'll look into that.

@funtri-vt

funtri-vt commented Jun 12, 2026

Copy link
Copy Markdown
Author

Just realized that Linux-base being upgraded might be a problem. I'll look into that.

Testing a reboot after manually adding this repo to my shimboot install and upgrading it. I'll see if it breaks anything.

@funtri-vt

Copy link
Copy Markdown
Author

It seems it hasn't broken. That means this PR is probably ready to be merged (ofc only if ading2210 wants).

@jacobleclair

Copy link
Copy Markdown

this is how i've always used it, haven't had issues.

@funtri-vt funtri-vt left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is how i've always used it, haven't had issues.

Well, I came accross this after learning about the latest ffmpeg vulnerabilites(which i had ffmpeg installed on my shimboot system) and when trying to update, it refused to update to the latest version, so I investigated and found that the security repository wasn't enabled. So, I made this simple patch to fix that, and add the security repo so shimboot is a little more secure than it currently is(when you factor out the old kernel, which kexec support for is in progress, but not yet finished).

Comment thread rootfs/opt/setup_rootfs.sh Outdated
modify build_rootfs to pass in the security repo passed by build_complete.sh

@funtri-vt funtri-vt left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok! I've pushed a patch to address that. Let me know if you'd like any improvements, or if it seems like it doesn't properly address the issue.

@funtri-vt

funtri-vt commented Jun 13, 2026

Copy link
Copy Markdown
Author

Just realized that I'm not running an if on the distro to determine the repo. I'll fix that in a bit.

@funtri-vt funtri-vt left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also added a flag to include the security repos that can be expanded to add logic for ubuntu to build_complete for whether or not to even include the security repo. This also by default sets up the prebuilts to use the security repo. Let me know if you'd like any changes before this is merged!

@funtri-vt funtri-vt changed the title Update setup_rootfs.sh to add debian security repo by default Enable Debian security repo by default Jun 16, 2026
@funtri-vt funtri-vt requested a review from ading2210 June 16, 2026 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants