Open
Conversation
Memcall functions work at the byte level so they don't know about
C++semantics and these C++ objects might not have trivial constructors
or destructors. I silenced the warning by explicitly casting the pointer
to void* with static_cast. I did this fix because it seems the code
developer knows the consequences with using memcall functions with C++
objects.
external/XMP-Toolkit-SDK/XMPFiles/source/FormatSupport/TIFF_Support.hpp:941:13:
error: first argument in call to 'memcpy' is a pointer to non-trivially
copyable type 'TIFF_FileWriter::InternalTagInfo'
[-Werror,-Wnontrivial-memcall]
941 | memcpy ( this, &in, sizeof(*this) );
// AUDIT: Use of sizeof(InternalTagInfo) is safe.
| ^
external/XMP-Toolkit-SDK/XMPFiles/source/FormatSupport/PSIR_Support.hpp:289:13:
error: first argument in call to 'memcpy' is a pointer to non-trivially
copyable type 'PSIR_FileWriter::InternalRsrcInfo'
[-Werror,-Wnontrivial-memcall]
289 | memcpy ( this, &in, sizeof(*this) );
// AUDIT: Use of sizeof(InternalRsrcInfo) is safe.
| ^
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Memcall functions work at the byte level so they don't know about C++semantics and these C++ objects might not have trivial constructors or destructors. Clang has started complaining about this with this warning (-Wnontrivial-memcall). I silenced the warning by explicitly casting the pointer to void* with static_cast. I did this fix because it seems the code developer knows the consequences with using memcall functions with C++ objects.
external/XMP-Toolkit-SDK/XMPFiles/source/FormatSupport/TIFF_Support.hpp:941:13: error: first argument in call to 'memcpy' is a pointer to non-trivially copyable type 'TIFF_FileWriter::InternalTagInfo'
[-Werror,-Wnontrivial-memcall]
941 | memcpy ( this, &in, sizeof(*this) );
// AUDIT: Use of sizeof(InternalTagInfo) is safe.
| ^
external/XMP-Toolkit-SDK/XMPFiles/source/FormatSupport/PSIR_Support.hpp:289:13: error: first argument in call to 'memcpy' is a pointer to non-trivially copyable type 'PSIR_FileWriter::InternalRsrcInfo'
[-Werror,-Wnontrivial-memcall]
289 | memcpy ( this, &in, sizeof(*this) );
// AUDIT: Use of sizeof(InternalRsrcInfo) is safe.
| ^
Related Issue
#111
Motivation and Context
How Has This Been Tested?
I built this repo with the change in Android and warnings disappear.
Screenshots (if appropriate):
Types of changes
Checklist: