Allign local secrets with worker by JSON-parsing string values.#293
Open
nvyasadobe wants to merge 3 commits intodevelopfrom
Open
Allign local secrets with worker by JSON-parsing string values.#293nvyasadobe wants to merge 3 commits intodevelopfrom
nvyasadobe wants to merge 3 commits intodevelopfrom
Conversation
romario-0
previously approved these changes
Apr 8, 2026
AjazSumaiya
reviewed
Apr 10, 2026
Contributor
AjazSumaiya
left a comment
There was a problem hiding this comment.
@nvyasadobe does this change has any tests added
romario-0
approved these changes
Apr 13, 2026
AjazSumaiya
approved these changes
Apr 13, 2026
bhairavi25
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Local
aio api-mesh runloads secrets from.mesh/secrets.yaml, stringifies them into the SECRETS env var, and the dev server parses that JSON.String values stayed strings, so paths like
context.secrets.TOKEN.COMMERCEfailed when TOKEN was authored as a JSON blob in YAML (e.g.TOKEN: '{"COMMERCE": "dummy-value"}').On the deployed tenant worker, each SECRETS__* binding is passed through JSON.parse when possible, so the same YAML shape becomes a nested object at runtime and those paths work.
Related Issue
https://jira.corp.adobe.com/browse/CEXT-6008
Motivation and Context
How Has This Been Tested?
TOKEN: '{"COMMERCE": "dummy-value"}'"secret3": "{context.secrets.TOKEN.COMMERCE}""secret3": "dummy-value"Screenshots (if appropriate):
Types of changes
Checklist: