Add schema support for Adobe Express Add-on Manifest#47
Add schema support for Adobe Express Add-on Manifest#47prasanta352 wants to merge 2 commits intoadobe:mainfrom
Conversation
- Added `express-add-on-manifest.schema.json` for validating & autocomplete add-on manifest files. - Introduced `copy-schema` script to copy schema files to template directories. - Updated `package.json` to include the new script. - Created `.vscode/settings.json` files in various templates to link the schema for VSCode integration. This update enhances the development experience by providing schema validation for add-on manifests across multiple templates.
| "clean": "rimraf coverage dist src/generated", | ||
| "test": "c8 mocha && c8 check-coverage" | ||
| "test": "c8 mocha && c8 check-coverage", | ||
| "copy-schema": "node scripts/copy-schema.js" |
There was a problem hiding this comment.
This creates a logical cycle. The @adobe/ccweb-add-on-manifest package sits at the very bottom of the dependency graph, where the other packages like @adobe/create-ccweb-add-on depend on it.
So, the copy-schema.js script from add-on-manifest writing to create-ccweb-add-on creates this cycle.
Please remove the changes made in the add-on-manifest package, skipping the copy-schema step.
It would be great, though if we could automatically generate express-add-on-manifest.schema.json. Could be a follow-up.
There was a problem hiding this comment.
Got it, thanks @xerxovksi As you mentioned, I have reverted the changes in @adobe/ccweb-add-on-manifest and skip the copy-schema step to avoid the cycle.
I also agree it would be good to auto-generate express-add-on-manifest.schema.json. Updating the docs to include optional types would be the prerequisite, otherwise the schema wouldn’t be accurate.
On which step do you think the auto-generation should happen once the docs are updated?
…t package. Updated `package.json` to remove the `copy-schema` script. This cleanup reduces unnecessary code and simplifies the project structure.
2 participants
Description
Add schema support for Adobe Express Add-on Manifest
express-add-on-manifest.schema.jsonfor validating & autocomplete add-on manifest files.copy-schemascript to copy schema files to template directories.package.jsonto include the new script..vscode/settings.jsonfiles in various templates to link the schema for VSCode integration.This update enhances the development experience by providing schema validation & autocomplete for add-on manifests across multiple templates.
Motivation and Context
Developers working on Adobe Express add-ons need better development experience when editing manifest.json files. This sample provides:
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: