feat: improve metadata size constraints for json-ld#1
Open
Conversation
buuhuu
changed the title
tripodsan
approved these changes
Jan 14, 2026
dylandepass
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far the metadata size assertion was checked against the pretty-printed version of the given json-ld. The pretty-printing may add a significant amount of whitespaces which reduce the actual amount of data that can be put into the json-ld. We had one example where the given json-ld string was 99.5k characters long and the pretty printed version 130k (+30%).
With this change I changed the order of the asserts to:
I preserved the pretty printing to keep whitespaces in the json-ld string and have it line-break in the grid table. This avoids other cells to contain too many white spaces when the json-ld string has no other whitespace that would allow a line break.
I also made the maximum metadata size configureable as
opts.maxMetadataSize