media-library : optimizations

[kmurugulla]

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #

Test URLs:

• Before: https://main--helix-tools-website--adobe.aem.live/tools/media-library/index.html
• After: https://media-bulk-status--helix-tools-website--adobe.aem.live/tools/media-library/index.html

[aem-code-sync]

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

• Re-run PSI checks
• Re-sync branch

Commits

• 19bc0d6 ✅ (latest)
• ccefc4a ✅
• d410b1a ✅
• 78733cc ✅
• aaff0e1 ✅
• 51ce8f0 ✅
• 26b5d11 ✅
• 4646444 ✅
• dde3d87 ✅
• 87f54d0 ✅
• ae0f35d ✅
• 0501aa2 ✅
• c6fbd04 ✅

[aem-code-sync]

	Page	Scores	Audits	Google
📱	/tools/media-library/index.html
🖥️	/tools/media-library/index.html

[claude]

Code review comment posted

[claude]

placeholder

[claude]

Code Review

Issues Found

BLOCKING:

• build.js — perf.medialog.* accessed unconditionally when perf defaults to null, causing a TypeError crash on incremental builds (inline suggestion posted)
• parse.js — Retry callback omits isSuccess from return value; success/fail counters and recovered set are always wrong after retries (inline suggestion posted)

SHOULD FIX:

• media-library.js — Two console.log statements fire unconditionally on every index run (not gated by isPerfEnabled()), violating the "no debug console.log" rule (inline suggestions posted)

One-Click Fixes

I have added GitHub Suggestions for all fixable issues. Go to Files changed and click Commit suggestion to apply each fix.

Verdict

REQUEST CHANGES

[claude]

Superseded by detailed review below - please ignore this entry.

[claude]

Code Review Summary. BLOCKING: (1) indexing/build.js ~line 103 -- Null dereference: perf.medialog.* accessed without null guard; perf defaults to null. Inconsistent with the if(perf and parseStats) guard used earlier in same function. (2) indexing/parse.js retry block -- isSuccess is never returned by the retry processConcurrently callback, making counter adjustments and recovery tracking completely dead code. Retried-but-successful pages permanently counted as failures in stats. SHOULD FIX: (1) media-library.js -- Two unconditional console.log calls (index start + end) fire for ALL users on every index. All other console.log in this PR are correctly gated behind isPerfEnabled(). Violates CLAUDE.md no-debug-console.log rule. (2) PR description -- After preview URL uses .aem.live (production) instead of .aem.page (feature branch preview). Correct URL: https://media-bulk-status--helix-tools-website--adobe.aem.page/tools/media-library/index.html. One-Click Fixes: A GitHub Suggestion has been added for the parse.js bug. Go to Files changed and click Commit suggestion to apply. Verdict: REQUEST CHANGES