fix(sitemap-admin): dialog cleanup, accessibility, and UX fixes

[shsteimer]

Summary

Part 1 of 2 replacing #252, which combined cleanup/fixes with new features. This PR contains only the fixes and cleanup; the sitemap index definition viewer will follow in a separate PR.

• Extract cleanupDialog/registerDialogCleanup helpers so dialogs are properly removed on close, cancel, and Escape
• Add aria-labelledby to all dialog templates for screen reader support
• Fix 204 response handling in generateSitemap to avoid calling resp.json() on empty body
• Wrap generate button reset in try/finally so it recovers on errors
• Deduplicate YAML import into ensureYaml() helper
• Fix CSS specificity for type dialog button area
• Auto-submit form when org/site query params are present

Preview: https://fix-sitemap-admin-cleanup--helix-tools-website--adobe.aem.page/tools/sitemap-admin/index.html

Test plan

• Dismiss each sitemap dialog via Escape, then reopen it and verify a fresh dialog opens correctly
• Dismiss each dialog via cancel button and backdrop click, then verify reopening still works
• Verify all dialogs expose the correct accessible name from their headings (check with screen reader or dev tools)
• Verify the type-selection dialog cancel area is laid out correctly
• Generate a sitemap for a configured destination and verify success
• Generate a sitemap for a path that is not a configured destination and verify the 204 response is handled gracefully without leaving the button disabled
• Load the page with ?org=<org>&site=<site> and verify the form auto-submits

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com

[aem-code-sync]

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

• Re-run PSI checks
• Re-sync branch

Commits

• fe51ee3 ✅ (latest)
• a882206 ✅
• dbcf559 ✅

[aem-code-sync]

	Page	Scores	Audits	Google
📱	/tools/sitemap-admin/index.html
🖥️	/tools/sitemap-admin/index.html

[claude]

Code Review

Files Reviewed

• tools/sitemap-admin/index.html
• tools/sitemap-admin/sitemap-admin.css
• tools/sitemap-admin/sitemap-admin.js

Issues Found

None. Checked for bugs, CLAUDE.md compliance, and EDS-specific criteria (JS patterns, CSS scoping, accessibility, security, performance).

Highlights

• 204 fix — correctly guards against calling .json() on an empty response body; logic is sound
• Dialog cleanup — cleanupDialog + registerDialogCleanup correctly handle Escape-key dismiss; double .remove() calls on detached elements are harmless no-ops
• Accessibility — aria-labelledby additions correctly associate each <dialog> with its <h3> heading; IDs inside <template> elements don't create live DOM duplicates
• CSS scoping — .sitemap-type-button-area remains properly scoped via CSS nesting inside .sitemap-admin
• ensureYaml() — deduplication is correct; any concurrent-call race results only in a redundant (harmless) dynamic import
• Auto-submit — requestSubmit() fires after the submit listener is registered and only when both org and site values are populated; submit handler has its own guard

Verdict

APPROVE