chore: surface token when applying auth, allow named secret creation#285
Open
usman-khalid wants to merge 3 commits intomainfrom
Open
chore: surface token when applying auth, allow named secret creation#285usman-khalid wants to merge 3 commits intomainfrom
usman-khalid wants to merge 3 commits intomainfrom
Conversation
|
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
| <input type="text" id="secret-name" placeholder="e.g. my-secret-name" /> | ||
| </div> | ||
| <div class="form-field"> | ||
| <label for="secret-value">Value (optional)</label> |
Contributor
There was a problem hiding this comment.
SHOULD FIX: Secret value input should use type="password" to mask the value on screen.
The auth token display in the same PR correctly uses type="password". Per AGENTS.md: Consider that everything you do is client-side code served on the public web.
Suggested change
| <label for="secret-value">Value (optional)</label> | |
| <input type="password" id="secret-value" placeholder="e.g. secret from external service" /> |
Contributor
Code Review SummaryIssues FoundSHOULD FIX:
One-Click FixesI have added a GitHub Suggestion for the fixable issue. Go to Files changed and click Commit suggestion to apply. VerdictCOMMENT — one security hygiene fix recommended before merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates Site Admin tool to:
Test URLs: