Skip to content

fix(optel): saved reports should not be visible when domain is missing#286

Merged
asthabh23 merged 1 commit intomainfrom
optel-fix
Apr 15, 2026
Merged

fix(optel): saved reports should not be visible when domain is missing#286
asthabh23 merged 1 commit intomainfrom
optel-fix

Conversation

@asthabh23
Copy link
Copy Markdown
Member

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Test URLs:

@aem-code-sync
Copy link
Copy Markdown

aem-code-sync bot commented Apr 14, 2026

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync
Copy link
Copy Markdown

aem-code-sync bot commented Apr 14, 2026

Page Scores Audits Google
📱 /tools/optel/oversight/explorer.html PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /tools/optel/oversight/explorer.html PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@asthabh23 asthabh23 requested a review from trieloff April 14, 2026 08:27
@claude
Copy link
Copy Markdown
Contributor

claude bot commented Apr 14, 2026

Code Review

No issues found. Checked for bugs and CLAUDE.md compliance.

Files reviewed:

  • blocks/ai-optel-report-generator/reports/da-upload.js
  • blocks/ai-optel-report-generator/reports/report-state.js

Checks performed:

  • CLAUDE.md / AGENTS.md compliance (JavaScript ES6+, Airbnb ESLint rules, security)
  • EDS-specific criteria (no debug statements, no secrets, no XSS, no aem.js modification)
  • Bug scan (logic errors, missing imports, API misuse)
  • Security and logic review

Verdict

APPROVE

@asthabh23 asthabh23 merged commit 2053a2a into main Apr 15, 2026
6 of 7 checks passed
@asthabh23 asthabh23 deleted the optel-fix branch April 15, 2026 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants