Skip to content

fix: Add button role to sortable column header text in Table starters #10364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dudusotero wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −3
Open

fix: Add button role to sortable column header text in Table starters #10364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/react-aria-components/src/Group.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,12 @@ export interface GroupProps
* Use `'region'` when the contents of the group is important enough to be
* included in the page table of contents. Use `'presentation'` if the group
* is visual only and does not represent a semantic grouping of controls.
* Use `'button'` when the group wraps focusable text that forwards clicks
* to a parent control, such as the text of a sortable table column header.
*
* @default 'group'
*/
role?: 'group' | 'region' | 'presentation';
role?: 'group' | 'region' | 'presentation' | 'button';
}

export const GroupContext = createContext<ContextValue<GroupProps, HTMLDivElement>>({});
Expand Down
5 changes: 4 additions & 1 deletion starters/docs/src/Table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,10 @@ export function Column(props: Omit<ColumnProps, 'children'> & {children?: React.
<AriaColumn {...props} className="react-aria-Column button-base">
{({allowsSorting, sortDirection}) => (
<div className="column-header">
<Group role="presentation" tabIndex={-1} className="column-name">
<Group

@snowystinger snowystinger Aug 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want to add role="button" to Group. Instead, I think we should render a button here if that's what's needed and a presentational element if not. It can be a div with role="button" if that makes it easier, we don't need to use a component like Group. I'm actually not sure what it's doing for us here, RAC doesn't use the GroupContext for Columns

role={allowsSorting ? 'button' : 'presentation'}
tabIndex={-1}
className="column-name">
{props.children}
</Group>
{allowsSorting && (
Expand Down
5 changes: 4 additions & 1 deletion starters/tailwind/src/Table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,10 @@ export function Column(props: ColumnProps) {
)}>
{composeRenderProps(props.children, (children, {allowsSorting, sortDirection}) => (
<div className="flex items-center">
<Group role="presentation" tabIndex={-1} className={columnStyles}>
<Group
role={allowsSorting ? 'button' : 'presentation'}
tabIndex={-1}
className={columnStyles}>
<span className="truncate">{children}</span>
{allowsSorting && (
<span
Expand Down