Skip to content

fix: tooltip prop spread in s2 docs examples #10413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
snowystinger wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

fix: tooltip prop spread in s2 docs examples #10413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/dev/s2-docs/pages/s2/Tooltip.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ import {Tooltip, TooltipTrigger} from '@react-spectrum/s2/Tooltip';
import {ActionButton} from '@react-spectrum/s2/ActionButton';
import Edit from '@react-spectrum/s2/icons/Edit';

<TooltipTrigger>
<TooltipTrigger/* PROPS */>
<ActionButton aria-label="Edit name"><Edit /></ActionButton>
<Tooltip/* PROPS */>Edit name</Tooltip>
<Tooltip>Edit name</Tooltip>
</TooltipTrigger>
```

Expand Down
2 changes: 1 addition & 1 deletion packages/dev/s2-docs/src/VisualExampleClient.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,7 @@ function renderProp(name: string, value: any, control?: PropControl, indent = ''
</>
);
} else if (typeof value === 'boolean') {
if (value === false && control?.optional) {
if (value === false && control?.optional && !control?.default) {

@yihuiliao yihuiliao Aug 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of curiosity, what was this change for?

@snowystinger snowystinger Aug 3, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2026-08-04 at 6 27 39 am

prior to this change a "false" boolean would just be omitted

@yihuiliao yihuiliao Aug 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohh okay i see what you mean, ty

return null;
}
if (name === 'contextualHelp') {
Expand Down