fix: TokenField IME composition broken in Firefox - #10422
Open
chirokas wants to merge 1 commit into
Open
Conversation
chirokas
marked this pull request as ready for review
August 4, 2026 13:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
Unlike Chromium, Firefox does not select the composition text before replacing it during IME handling.
Firefox:
https://github.com/mozilla-firefox/firefox/blob/45135a4adb3c83c65c090e9c613775a5e193aba5/editor/libeditor/EditorBase.cpp#L4055-L4235
Chromium:
https://github.com/chromium/chromium/blob/2790129dcbdb4fa07d8bd2b282a74e56b26c40dd/third_party/blink/renderer/core/editing/ime/input_method_controller.cc#L1026
We should use the
getTargetRanges()method in thebeforeinputevent to get the composition range.Video.Project.mp4
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: