Conversation
|
📚 Branch Preview Links🔍 First Generation Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
…skill - The a11y migration analysis doc is a full authoring playbook, not a linting rule. Moves it from .ai/rules/ to .ai/skills/ with a SKILL.md that mirrors the component-migration-analysis skill structure. - Also fixes a stale .cursor/ path reference in component-migration-analysis/SKILL.md.
- Delete .cursor/README.md and .cursor/config.json - Delete all skill files under .cursor/skills/
7bdadee to
117b2a4
Compare
41db1cf to
7771aab
Compare
Description
Can be merged directly into feat-agnostic-ai-folder-stuff before or after the washing machine skills PR #6127 or the skills mindset PR #6139
Adds a
.aiskill (pr-review) for performing automated first-round code reviews before opening a PR to the team. The skill compares the current branch against a base branch, inspects the diff, runs targeted checks against repo guidance, and writes a structured review report to.ai/pr-feedback/(which is git-ignored).Changes:
.ai/skills/pr-review/SKILL.md: skill definition and workflow.ai/skills/pr-review/references/pr-review-prompt.md: reference prompt driving the review logic.ai/skills/pr-review/references/pr-feedback-template.md: output template for generated review reports.ai/skills/pr-review/scripts/create_pr_feedback.py: Python script that scaffolds the feedback file.ai/README.md: updated to document the new skill.gitignore: excludes.ai/pr-feedbackMotivation and context
Code review feedback is only useful if it's consistent and tied to the project's own conventions. This skill gives contributors a first-pass review grounded in 2nd-gen component guidance — CSS style, TypeScript patterns, accessibility, and testing — before the PR reaches the team. It reduces review cycle time and surfaces fixable issues early.
Related issue(s)
Screenshots (if appropriate)
Author's checklist
Reviewer's checklist
patch,minor, ormajorfeaturesManual review test cases
pr-reviewskillcreate_pr_feedback.pyto scaffold a numbered file in.ai/pr-feedback/mainbase branch (e.g.marissahuysentruyt/feat-agnostic-folder-ai-stuff)Device review
Accessibility testing checklist
Required: Complete each applicable item and document your testing steps (replace the placeholders with your component-specific instructions).
Keyboard
documentation update only
Screen reader
documentation update only