Skip to content

feat(.ai): code review skill#6148

Draft
marissahuysentruyt wants to merge 20 commits intomainfrom
marissahuysentruyt/feat-code-review-skill
Draft

feat(.ai): code review skill#6148
marissahuysentruyt wants to merge 20 commits intomainfrom
marissahuysentruyt/feat-code-review-skill

Conversation

@marissahuysentruyt
Copy link
Copy Markdown
Collaborator

@marissahuysentruyt marissahuysentruyt commented Apr 7, 2026

Description

⚠️ NICE-TO-HAVE PARALLEL MERGE ⚠️
Can be merged directly into feat-agnostic-ai-folder-stuff before or after the washing machine skills PR #6127 or the skills mindset PR #6139

Adds a .ai skill (pr-review) for performing automated first-round code reviews before opening a PR to the team. The skill compares the current branch against a base branch, inspects the diff, runs targeted checks against repo guidance, and writes a structured review report to .ai/pr-feedback/ (which is git-ignored).

Changes:

  • .ai/skills/pr-review/SKILL.md: skill definition and workflow
  • .ai/skills/pr-review/references/pr-review-prompt.md: reference prompt driving the review logic
  • .ai/skills/pr-review/references/pr-feedback-template.md: output template for generated review reports
  • .ai/skills/pr-review/scripts/create_pr_feedback.py: Python script that scaffolds the feedback file
  • .ai/README.md: updated to document the new skill
  • .gitignore: excludes .ai/pr-feedback

Motivation and context

Code review feedback is only useful if it's consistent and tied to the project's own conventions. This skill gives contributors a first-pass review grounded in 2nd-gen component guidance — CSS style, TypeScript patterns, accessibility, and testing — before the PR reaches the team. It reduces review cycle time and surfaces fixable issues early.

Related issue(s)

  • fixes swc-1895

Screenshots (if appropriate)


Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
  • I have added automated tests to cover my changes.
  • I have included a well-written changeset if my change needs to be published.
  • I have included updated documentation if my change required it.

Reviewer's checklist

  • Includes a Github Issue with appropriate flag or Jira ticket number without a link
  • Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
  • Automated tests cover all use cases and follow best practices for writing
  • Validated on all supported browsers
  • All VRTs are approved before the author can update Golden Hash

Manual review test cases

  • PR review skill generates a valid feedback report
  1. On a branch with 2nd-gen component changes, invoke the pr-review skill
  2. Expect create_pr_feedback.py to scaffold a numbered file in .ai/pr-feedback/
  3. Expect the report to include findings organized by the template structure (CSS, TypeScript, accessibility, testing)
  • Skill correctly uses a custom base branch when specified
  1. Invoke the skill with a non-main base branch (e.g. marissahuysentruyt/feat-agnostic-folder-ai-stuff)
  2. Expect the diff and review to reflect only the commits on the current branch vs that base

Device review

  • Did it pass in Desktop?
  • Did it pass in (emulated) Mobile?
  • Did it pass in (emulated) iPad?

Accessibility testing checklist

Required: Complete each applicable item and document your testing steps (replace the placeholders with your component-specific instructions).

  • Keyboard
    documentation update only

  • Screen reader
    documentation update only

@marissahuysentruyt marissahuysentruyt self-assigned this Apr 7, 2026
@marissahuysentruyt marissahuysentruyt added Status:WIP PR is a work in progress or draft 1.0.0 Issues that should be addressed for a 1.0 release! Component:Tooling Issue or PR dealing with scripts, workflows, automation, etc. Component prefix is for Jira do-not-merge NO MERGE-Y! 2nd gen These issues or PRs map to our 2nd generation work to modernizing infrastructure. labels Apr 7, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 7, 2026

⚠️ No Changeset found

Latest commit: 7771aab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

📚 Branch Preview Links

🔍 First Generation Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Deployed to Azure Blob Storage: pr-6148

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

…skill

- The a11y migration analysis doc is a full authoring playbook, not a
linting rule. Moves it from .ai/rules/ to .ai/skills/ with a SKILL.md
that mirrors the component-migration-analysis skill structure.

- Also fixes a stale .cursor/ path reference in
component-migration-analysis/SKILL.md.
- Delete .cursor/README.md and .cursor/config.json
- Delete all skill files under .cursor/skills/
@marissahuysentruyt marissahuysentruyt force-pushed the marissahuysentruyt/feat-agnostic-folder-ai-stuff branch from 7bdadee to 117b2a4 Compare April 8, 2026 17:21
@marissahuysentruyt marissahuysentruyt force-pushed the marissahuysentruyt/feat-code-review-skill branch from 41db1cf to 7771aab Compare April 8, 2026 18:09
Base automatically changed from marissahuysentruyt/feat-agnostic-folder-ai-stuff to main April 13, 2026 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.0.0 Issues that should be addressed for a 1.0 release! 2nd gen These issues or PRs map to our 2nd generation work to modernizing infrastructure. Component:Tooling Issue or PR dealing with scripts, workflows, automation, etc. Component prefix is for Jira do-not-merge NO MERGE-Y! Status:WIP PR is a work in progress or draft

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant