chore(core): remove 1st-gen type references from 2nd-gen core#6168
chore(core): remove 1st-gen type references from 2nd-gen core#6168cdransf merged 5 commits intoswc-1668/poc-componentsfrom
Conversation
|
📚 Branch Preview Links🔍 First Generation Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
7e8625b to
c3f57ef
Compare
b82a201 to
13ec464
Compare
e0d3061 to
b446021
Compare
13ec464 to
8f201a5
Compare
Description
Removes S1-only constants, types, and runtime guards from 2nd-gen core files now that 1st-gen packages no longer
depend on
@spectrum-web-components/core.Badge.types.ts: removesBADGE_VARIANTS_COLOR_S1,BADGE_VARIANTS_S1,BadgeColorVariantS1,BadgeVariantS1StatusLight.types.ts: removesSTATUSLIGHT_VARIANTS_SEMANTIC_S1,STATUSLIGHT_VARIANTS_COLOR_S1,STATUSLIGHT_VARIANTS_S1and their corresponding types; simplifies type aliases to S2-onlyProgressCircle.types.ts: removesPROGRESS_CIRCLE_STATIC_COLORS_S1andProgressCircleStaticColorS1;inlines values into the S2 constant
AlertBanner.types.ts: removes deprecatedAlertBannerVariantsbackward-compat typeStatusLight.base.ts: removes S1-onlydisabledattribute runtime warningswc/Badge.ts: removes stale@todocomments onsubtleandoutlineMotivation and context
PR #6126 decoupled 1st-gen packages from
@spectrum-web-components/coreby inlining shared code locally. TheS1-specific exports in core were kept solely to support that cross-generation dependency, which no longer
exists.
Related issue(s)
SWC-1885
Author's checklist
CONTRIBUTING and
PULL_REQUESTS documents.
Practices
Reviewer's checklist
Manual review test cases
yarn buildin2nd-gen/packages/coreDevice review
Accessibility testing checklist
Types and constants only — no component behavior or rendering changed. No accessibility testing required.