Skip to content

chore(core): remove 1st-gen type references from 2nd-gen core#6168

Merged
cdransf merged 5 commits intoswc-1668/poc-componentsfrom
cdransf/clean-1st-gen-references
Apr 14, 2026
Merged

chore(core): remove 1st-gen type references from 2nd-gen core#6168
cdransf merged 5 commits intoswc-1668/poc-componentsfrom
cdransf/clean-1st-gen-references

Conversation

@cdransf
Copy link
Copy Markdown
Member

@cdransf cdransf commented Apr 10, 2026

Description

Removes S1-only constants, types, and runtime guards from 2nd-gen core files now that 1st-gen packages no longer
depend on @spectrum-web-components/core.

  • Badge.types.ts: removes BADGE_VARIANTS_COLOR_S1, BADGE_VARIANTS_S1, BadgeColorVariantS1,
    BadgeVariantS1
  • StatusLight.types.ts: removes STATUSLIGHT_VARIANTS_SEMANTIC_S1, STATUSLIGHT_VARIANTS_COLOR_S1,
    STATUSLIGHT_VARIANTS_S1 and their corresponding types; simplifies type aliases to S2-only
  • ProgressCircle.types.ts: removes PROGRESS_CIRCLE_STATIC_COLORS_S1 and ProgressCircleStaticColorS1;
    inlines values into the S2 constant
  • AlertBanner.types.ts: removes deprecated AlertBannerVariants backward-compat type
  • StatusLight.base.ts: removes S1-only disabled attribute runtime warning
  • swc/Badge.ts: removes stale @todo comments on subtle and outline

Motivation and context

PR #6126 decoupled 1st-gen packages from @spectrum-web-components/core by inlining shared code locally. The
S1-specific exports in core were kept solely to support that cross-generation dependency, which no longer
exists.

Related issue(s)

SWC-1885

Author's checklist

Reviewer's checklist

  • Includes a Github Issue with appropriate flag or Jira ticket number without a link
  • Automated tests cover all use cases and follow best practices for writing
  • Validated on all supported browsers
  • All VRTs are approved before the author can update Golden Hash

Manual review test cases

  • Verify no TypeScript errors after removing S1 types
  1. Pull the branch and run yarn build in 2nd-gen/packages/core
  2. Confirm no type errors referencing removed S1 symbols

Device review

  • Did it pass in Desktop?
  • Did it pass in (emulated) Mobile?
  • Did it pass in (emulated) iPad?

Accessibility testing checklist

Types and constants only — no component behavior or rendering changed. No accessibility testing required.

@cdransf cdransf self-assigned this Apr 10, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 10, 2026

⚠️ No Changeset found

Latest commit: 9b026c5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 10, 2026

📚 Branch Preview Links

🔍 First Generation Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Deployed to Azure Blob Storage: pr-6168

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

@cdransf cdransf force-pushed the cdransf/clean-1st-gen-references branch from 7e8625b to c3f57ef Compare April 14, 2026 16:06
@cdransf cdransf marked this pull request as ready for review April 14, 2026 16:49
@cdransf cdransf requested a review from a team as a code owner April 14, 2026 16:49
@cdransf cdransf added the Status:Ready for review PR ready for review or re-review. label Apr 14, 2026
@cdransf cdransf changed the base branch from main to swc-1668/poc-components April 14, 2026 16:55
@cdransf cdransf force-pushed the cdransf/clean-1st-gen-references branch 2 times, most recently from b82a201 to 13ec464 Compare April 14, 2026 16:58
@cdransf cdransf force-pushed the swc-1668/poc-components branch from e0d3061 to b446021 Compare April 14, 2026 17:03
@cdransf cdransf force-pushed the cdransf/clean-1st-gen-references branch from 13ec464 to 8f201a5 Compare April 14, 2026 17:05
@cdransf cdransf merged commit 7295f25 into swc-1668/poc-components Apr 14, 2026
6 of 24 checks passed
@cdransf cdransf deleted the cdransf/clean-1st-gen-references branch April 14, 2026 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status:Ready for review PR ready for review or re-review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants