feat(illustrated-message): slot-based heading API + gen1 deprecation#6173
Conversation
|
📚 Branch Preview Links🔍 First Generation Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
…nd add heading slot validation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
df19146 to
b1b6d48
Compare
5t3ph
left a comment
There was a problem hiding this comment.
Nice, just two minor things to consider!
…operty-level warnings
5t3ph
left a comment
There was a problem hiding this comment.
New warnings look good! One tiny suggestion on the new docs.
…rning structure" for clarity
… instead of every updated()
…y, guard warn inside method
Description
2nd-gen
heading-levelprop fromswc-illustrated-message. The consumer now provides an<h2>–<h6>element directly in theheadingslot — the component no longer owns the heading tag or level.::slotted(hN:not([class]))so component tokens can take over.@todo SWC-1943(slot constraints) and@todo SWC-1944(@status unsupported) to track follow-up work.<h2 slot="heading">.1st-gen
firstUpdateddeprecation warning onsp-illustrated-messagepointing to https://s2.spectrum.adobe.com/.Motivation and context
The previous API had the shadow DOM own the heading tag (
<h2>–<h6>), controlled via aheading-levelprop. This is a breaking change that simplifies the API — consumers own their heading semantics, which is more consistent with how slots are used across the design system and gives teams direct control over document outline hierarchy.The gen1
sp-illustrated-messageis no longer maintained. The deprecation warning directs consumers to Spectrum 2.Related issue(s)
Screenshots (if appropriate)
Author's checklist
Reviewer's checklist
patch,minor, ormajorfeaturesManual review test cases
Heading slot renders correctly with consumer-provided heading element
<h2 slot="heading">in light DOM<h2>–<h6>exists thereDeprecation warning fires for
sp-illustrated-messagein gen1[SWC] DEPRECATION NOTICEwarning mentioning Spectrum 2Device review
Accessibility testing checklist
Keyboard (required — document steps below)
Screen reader (required — document steps below)
<h2>announces as "heading level 2")