Skip to content

build(deps): bump @asciidoctor/core from 4.0.5 to 4.0.6 - #1231

Merged
github-actions[bot] merged 1 commit into
mainfrom
dependabot/npm_and_yarn/asciidoctor/core-4.0.6
Jul 27, 2026
Merged

build(deps): bump @asciidoctor/core from 4.0.5 to 4.0.6#1231
github-actions[bot] merged 1 commit into
mainfrom
dependabot/npm_and_yarn/asciidoctor/core-4.0.6

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Jul 27, 2026

Copy link
Copy Markdown
Contributor

Bumps @asciidoctor/core from 4.0.5 to 4.0.6.

Release notes

Sourced from @​asciidoctor/core's releases.

v4.0.6

Summary

Release meta

Released on: 2026-07-26 Released by: ggrossetie Published by: GitHub

Logs: full diff

Changelog

Bug Fixes

  • Fix AbstractNode#imageUri() no longer percent-encoding spaces in a data: URI image target (e.g. image::data:image/svg+xml,<svg ...><text>a b</text></svg>[]), a regression from the data URI image target support added for inline SVG embedding. That change short-circuited imageUri() for any data: target by returning it unchanged, bypassing the space-encoding that normalizeWebPath() still applies for every other URI-ish target — and that upstream Asciidoctor (Ruby) also applies, since image_uri has no data:-specific early return at all. imageUri() now runs data: targets through encodeSpacesInUri() before returning them, matching Ruby’s output byte-for-byte, while still avoiding the spurious could not retrieve image data from URI warning the earlier fix was meant to prevent
  • Fix tasks/changelog.js notes (used to generate GitHub release notes) leaving AsciiDoc attribute references such as [#1857](https://github.com/asciidoctor/asciidoctor.js/issues/1857) unresolved in the generated Markdown. extractReleaseNotes used to extract the raw AsciiDoc section for a release and convert only that fragment to Markdown, losing the :uri-repo: attribute definition from the changelog header in the process. The whole changelog is now converted to Markdown once, and the release section is extracted from the resulting Markdown instead, so attribute references resolve correctly
  • Type Logger#warn()/#debug()/#info()/#error()/#fatal()/#unknown()/#log() (and the matching MemoryLogger methods) with an optional progname/pn parameter instead of a required one. The generated .d.ts previously declared both arguments as mandatory, so calling doc.getLogger().warn(doc.messageWithContext(...)) with a single argument — the documented pattern for logging from an extension — was flagged by editors as "expected 2 arguments" even though it is valid at runtime; the error surfaced because getLogger() resolves to the LoggerLike union (Logger | MemoryLogger | NullLogger | Console) and TypeScript requires a call to satisfy every member’s signature
  • Type messageWithContext()/createLogMessage() on Document, ConverterBase, PathResolver, and Table.ParserContext (and the static equivalents on Parser). These are installed at runtime by the applyLogging() mixin (logging.js) after the class body closes, so tsc’s JSDoc-based declaration emit never picked them up — doc.messageWithContext(...)`, the pattern shown in the extensions guide, previously had no type at all on the public API surface

Infrastructure

  • Add compile-only type tests for the Logger/MemoryLogger/NullLogger API and the LoggerLike union (test/types/logging.test-d.ts, run by npm run test:types), covering every shorthand log method across single- and two-argument call forms, the applyLogging() consumers listed above, and negative @ts-expect-error checks (e.g. fatal()/unknown() are intentionally unavailable on the raw LoggerLike union because Console has neither, but resolve once narrowed away from Console)
Changelog

Sourced from @​asciidoctor/core's changelog.

== v4.0.6 (2026-07-26)

Bug Fixes::

  • Fix AbstractNode#imageUri() no longer percent-encoding spaces in a data: URI image target (e.g. image::data:image/svg+xml,<svg ...><text>a b</text></svg>[]), a regression from the data URI image target support added for inline SVG embedding. That change short-circuited imageUri() for any data: target by returning it unchanged, bypassing the space-encoding that normalizeWebPath() still applies for every other URI-ish target — and that upstream Asciidoctor (Ruby) also applies, since image_uri has no data:-specific early return at all. imageUri() now runs data: targets through encodeSpacesInUri() before returning them, matching Ruby's output byte-for-byte, while still avoiding the spurious could not retrieve image data from URI warning the earlier fix was meant to prevent
  • Fix tasks/changelog.js notes (used to generate GitHub release notes) leaving AsciiDoc attribute references such as {uri-repo}/issues/1857[#1857](https://github.com/asciidoctor/asciidoctor.js/issues/1857) unresolved in the generated Markdown. extractReleaseNotes used to extract the raw AsciiDoc section for a release and convert only that fragment to Markdown, losing the :uri-repo: attribute definition from the changelog header in the process. The whole changelog is now converted to Markdown once, and the release section is extracted from the resulting Markdown instead, so attribute references resolve correctly
  • Type Logger#warn()/#debug()/#info()/#error()/#fatal()/#unknown()/#log() (and the matching MemoryLogger methods) with an optional progname/pn parameter instead of a required one. The generated .d.ts previously declared both arguments as mandatory, so calling doc.getLogger().warn(doc.messageWithContext(...)) with a single argument — the documented pattern for logging from an extension — was flagged by editors as "expected 2 arguments" even though it is valid at runtime; the error surfaced because getLogger() resolves to the LoggerLike union (Logger | MemoryLogger | NullLogger | Console) and TypeScript requires a call to satisfy every member's signature
  • Type messageWithContext()/createLogMessage() on Document, ConverterBase, PathResolver, and Table.ParserContext (and the static equivalents on Parser). These are installed at runtime by the applyLogging() mixin (logging.js) after the class body closes, so tsc's JSDoc-based declaration emit never picked them up — doc.messageWithContext(...), the pattern shown in the extensions guide, previously had no type at all on the public API surface

Infrastructure::

  • Add compile-only type tests for the Logger/MemoryLogger/NullLogger API and the LoggerLike union (test/types/logging.test-d.ts, run by npm run test:types), covering every shorthand log method across single- and two-argument call forms, the applyLogging() consumers listed above, and negative @ts-expect-error checks (e.g. fatal()/unknown() are intentionally unavailable on the raw LoggerLike union because Console has neither, but resolve once narrowed away from Console)
Commits
  • 4c53894 4.0.6
  • 8dc9784 fix(core): encode spaces in data: URI image targets
  • f1c93e5 fix(core): type Logger progname as optional, close applyLogging() type gaps
  • 08b4092 fix(tasks): resolve AsciiDoc attribute references in generated release notes
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [@asciidoctor/core](https://github.com/asciidoctor/asciidoctor.js) from 4.0.5 to 4.0.6.
- [Release notes](https://github.com/asciidoctor/asciidoctor.js/releases)
- [Changelog](https://github.com/asciidoctor/asciidoctor.js/blob/main/CHANGELOG.adoc)
- [Commits](asciidoctor/asciidoctor.js@v4.0.5...v4.0.6)

---
updated-dependencies:
- dependency-name: "@asciidoctor/core"
  dependency-version: 4.0.6
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Jul 27, 2026
@netlify

netlify Bot commented Jul 27, 2026

Copy link
Copy Markdown

Deploy Preview for adoptium-next ready!

Name Link
🔨 Latest commit 7c5967d
🔍 Latest deploy log https://app.netlify.com/projects/adoptium-next/deploys/6a67263c235d1f000915162f
😎 Deploy Preview https://deploy-preview-1231--adoptium-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
github-actions Bot enabled auto-merge (squash) July 27, 2026 09:35
@github-actions
github-actions Bot merged commit 6e4decc into main Jul 27, 2026
18 checks passed
@github-actions
github-actions Bot deleted the dependabot/npm_and_yarn/asciidoctor/core-4.0.6 branch July 27, 2026 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants