Improve the variable name 'customUrl' to 'testDependencyUrl'

[Amrutha-Kanhirathingal]

Renamed customUrl to testDependencyUrl
Related :#6461
Closes :#6865

[Amrutha-Kanhirathingal]

Hi @annaibm ,@smlambert could you please review the changes?

[Amrutha-Kanhirathingal]

sanity.system : https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/58515/console
sanity.functional :https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/58516/console

[annaibm]

@Amrutha-Kanhirathingal Could you delete the cached dependency on the test machine and rerun? The test log shows the dependency already existed with the correct hash, so getDependencies.pl skipped the download entirely — the -testDependencyUrl flag was never actually used. We need to verify the flow where the custom URL is used (i.e., when the dependency is missing or the SHA doesn't match), to confirm the renamed flag works end-to-end.

init:
04:34:38      [mkdir] Created dir: /home/jenkins/workspace/Grinder/aqa-tests/TKG/bin
04:34:38  
04:34:38  getDependentLibs:
04:34:41       [exec] --------------------------------------------
04:34:41       [exec] path is set to /home/jenkins/workspace/Grinder/../../externalDependency/system_lib
04:34:41       [exec] task is set to default
04:34:41       [exec] dependencyList is set to json_simple
04:34:41       [exec] System Test jars will be downloaded.
04:34:41       [exec] --------------------------------------------
04:34:41       [exec] Starting download third party dependent jars
04:34:41       [exec] --------------------------------------------
04:34:41       [exec] downloading dependent third party jars to /home/jenkins/workspace/Grinder/../../externalDependency/system_lib
04:34:41       [exec] /home/jenkins/workspace/Grinder/../../externalDependency/system_lib/json-simple.jar exists with correct hash, not downloading
04:34:41       [exec] downloaded dependent third party jars successfully
04:34:41  

[annaibm]

Also I think we need a companion TKG change as well, I see in TKG
https://github.com/adoptium/TKG/blob/master/scripts/getDependencies.pl#L51 which uses

customUrl = $ENV{'CUSTOM_URL'} if ...;

→ to be $testDependencyUrl = $ENV{'TEST_DEPENDENCY_URL'}
Please do verify other occurrences as well which might be failing when running through our JenkinsfileBase in release jobs..

[Amrutha-Kanhirathingal]

Also I think we need a companion TKG change as well, I see in TKG https://github.com/adoptium/TKG/blob/master/scripts/getDependencies.pl#L51 which uses

customUrl = $ENV{'CUSTOM_URL'} if ...;

→ to be $testDependencyUrl = $ENV{'TEST_DEPENDENCY_URL'} Please do verify other occurrences as well which might be failing when running through our JenkinsfileBase in release jobs..

I have already raised a PR for related changes in TKG.Kindly have a look into this.
adoptium/TKG#812

[Amrutha-Kanhirathingal]

Logs after clearing the dependencies and jars are downloaded using renamed test Dependency Url
Sanity.System https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/58615/console
Sanity.Functional :https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/58612/consoleFull

[annaibm]

Sanity.System https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/58615/console
Sanity.Functional :https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/58612/consoleFull

@Amrutha-Kanhirathingal
Could you run a full test for both sanity.system and non-system (say sanity.functional) I see only one test ran, ensuring that the cached externalDependency directory is removed from the machine before running?

[Amrutha-Kanhirathingal]

The test flow will be same for all tests since only the variable was renamed.
All tests are executed after clearing external libraries using Cleanup_Test_Lib Job.
sanity.system : https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/58830/console
Sanity.functional : https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/58831/

[annaibm]

LGTM