Add readonly session policy for helper and subagent sessions - #41
Open
junyangyan4-svg wants to merge 1 commit into
Open
Add readonly session policy for helper and subagent sessions#41junyangyan4-svg wants to merge 1 commit into
junyangyan4-svg wants to merge 1 commit into
Conversation
junyangyan4-svg
marked this pull request as ready for review
April 6, 2026 05:35
adoresever
requested changes
Aug 1, 2026
adoresever
left a comment
Owner
There was a problem hiding this comment.
方向有价值,但当前实现与“子代理可消费继承的召回上下文”这一目标冲突:before_prompt_build 对只读会话直接返回,context engine 又把 activeNodes 清空,因此子代理实际上也失去读取能力。请只阻止写入、提取和维护,不要阻止读取继承/既有记忆;同时补充测试覆盖:父会话召回传递给子会话、子会话不能写、结束后状态清理、普通会话不受 helper 名称启发式误伤。完成后可继续评审。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gm_recordandgm_maintainin readonly sessions to make the policy explicitWhy
This isolates short-lived helper/subagent work from the shared graph so temporary execution chatter does not become long-term memory.
Split from #39.
Verification
npm testnpx tsc --noEmit