fix: address #49 #50 #46 (embed race, LLM signature, Node 24 compat) - #54
Open
zhuanxqq wants to merge 1 commit into
Open
fix: address #49 #50 #46 (embed race, LLM signature, Node 24 compat)#54zhuanxqq wants to merge 1 commit into
zhuanxqq wants to merge 1 commit into
Conversation
…esever#46, adoresever#44-related) - fix(llm): support LlmConfig object as first arg in createCompleteFn so direct-maintain.ts works without signature mismatch (adoresever#49) - fix(recaller): add embedReady promise to eliminate race condition between createEmbedFn and recall(), ensuring embedFn is always awaited before vector search (adoresever#50) - fix(build): migrate to NodeNext ESM + .js extensions for Node.js v24 compatibility, output dist/ and point package main there (adoresever#46) - chore(ports): searched codebase; no hardcoded 18787/18789 found, port mismatch lives outside this repo (adoresever#44) Tests: 80 passed. Build: dist/ generated successfully.
adoresever
requested changes
Aug 1, 2026
adoresever
left a comment
adoresever
left a comment
Owner
There was a problem hiding this comment.
这里包含可用的 embed race、LLM signature、Node 24 兼容修复，但同时混入了与本仓库运行模型不兼容的改动：入口改为未提交的 dist/index.js、排除全部测试编译、用本地 stub 替代真实 OpenClaw 类型，以及写死 ~/.hermes/环境文件的维护脚本。请基于最新 main rebase，并拆成独立 PR：保留每个问题的最小修复和回归测试，移除 Hermes 专用脚本、伪 SDK stub 与发布入口变更。这样可逐项合并。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes several open issues:
Verification:
RUN v1.6.1 /Users/hl/work/graph-memory
✓ test/extract.test.ts (22 tests) 6ms
✓ test/assemble.test.ts (11 tests) 12ms
✓ test/recall-community.test.ts (13 tests) 13ms
✓ test/store.test.ts (17 tests) 19ms
✓ test/graph.test.ts (17 tests) 15ms
Test Files 5 passed (5)
Tests 80 passed (80)
Start at 20:23:00
Duration 344ms (transform 279ms, setup 0ms, collect 464ms, tests 65ms, environment 0ms, prepare 317ms): 80/80 passed