3 update the stcc4 sensor code for the thermometer example#4
Merged
v2016e merged 25 commits intoJun 30, 2026
Merged
Conversation
BartolomeyKant
requested changes
Jun 17, 2026
| # include <freertos/FreeRTOS.h> | ||
| # include <freertos/task.h> | ||
|
|
||
| //#define I2C_LEGACY_DRIVER |
Collaborator
There was a problem hiding this comment.
Why left this commented?
| std::uint32_t humidity = {}; | ||
| std::uint32_t co2 = {}; | ||
| ReadSensors(&temperature, &humidity, nullptr, &co2, nullptr); | ||
| std::cout << ae::Format(" >>> Temperature: [{}]\n", temperature); |
Collaborator
There was a problem hiding this comment.
You could print all of this in one Format and std::cout call.
Like
std::cout << ae::Format(<All formats in one>, <list of all variables>)
|
|
||
| # Build directory | ||
| build/ | ||
| build*/**.cmake |
Collaborator
There was a problem hiding this comment.
You should list only build/ or build*/*
|
|
||
| # Write the value of the BOARD variable to this file | ||
| if(NOT "${BOARD}" STREQUAL "") | ||
| file(WRITE "${ULP_BOARD_FILE}" "set(BOARD \"${BOARD}\")\n") |
Collaborator
There was a problem hiding this comment.
This looks really complicated!
First of all you should use configure_file cmake command for this.
Did you check what BOARD variable is not visible inside ulp/CMakeLists.txt ?
BartolomeyKant
approved these changes
Jun 30, 2026
v2016e
deleted the
3-update-the-stcc4-sensor-code-for-the-thermometer-example
branch
June 30, 2026 12:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.