Update generate_infinite_expiry_signing_key.py#19
Open
volosianko77 wants to merge 1 commit intoaevoxyz:masterfrom
Open
Update generate_infinite_expiry_signing_key.py#19volosianko77 wants to merge 1 commit intoaevoxyz:masterfrom
volosianko77 wants to merge 1 commit intoaevoxyz:masterfrom
Conversation
volosianko77
commented
Mar 12, 2024
- Created a generate_signing_key function to encapsulate the logic for generating the signing key and related data.
- Moved the main logic into a main function.
- Used input to get the account private key from the user instead of hardcoding it.
- Improved function and variable names for better readability.
- Added docstrings to functions to explain their purpose.
- Modified the script to be more modular and easily extensible.
1. Created a generate_signing_key function to encapsulate the logic for generating the signing key and related data. 2. Moved the main logic into a main function. 3. Used input to get the account private key from the user instead of hardcoding it. 4. Improved function and variable names for better readability. 5. Added docstrings to functions to explain their purpose. 6. Modified the script to be more modular and easily extensible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.