-
Notifications
You must be signed in to change notification settings - Fork 0
feat: pluggable storage backend (local + S3-compatible) #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c2cd9b5
feat: pluggable storage backend (local + S3-compatible)
afa7789 82e0f5a
fix: address CI lint failures and Copilot review
afa7789 b42aa1d
fix: address PR review nitpicks
afa7789 74fe30c
fix: replace log.Fatalf with log.Printf+return in storage init
afa7789 21df9a8
fix: address PR review round 3
afa7789 b636d6c
fix: targeted improvement pass — symlink containment, error mapping, …
afa7789 4aa9550
fix: drop unused struct from s3_test.go
afa7789 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| package domain | ||
|
|
||
| import ( | ||
| "context" | ||
| "errors" | ||
| "io" | ||
| "time" | ||
| ) | ||
|
|
||
| var ( | ||
| ErrNotFound = errors.New("not found") | ||
| ErrInvalidInput = errors.New("invalid input") | ||
| ) | ||
|
|
||
| // Storage persists and retrieves binary objects (uploaded files, receipts, | ||
| // covers, etc.). Production impls: infrastructure/storage/local and | ||
| // infrastructure/storage/s3. | ||
| // | ||
| // URL contract — read carefully before persisting Upload's return value: | ||
| // | ||
| // - LocalStorage.Upload returns a stable, non-expiring relative path | ||
| // (e.g. "/static/covers/xyz.png") served by the app's static handler. | ||
| // Safe to persist in the database. | ||
| // | ||
| // - S3Storage.Upload returns a presigned GET URL valid for 24h. Storing | ||
| // it directly will produce broken links after expiry. Callers that | ||
| // need durable links should persist the key and call SignedURL on | ||
| // read, or proxy reads through the backend. | ||
| // | ||
| // SignedURL is always a time-limited URL. For LocalStorage it returns the | ||
| // same stable path as Upload (TTL is advisory and ignored). For S3Storage | ||
| // it returns a fresh presigned URL valid for ttl. | ||
| type Storage interface { | ||
| Upload(ctx context.Context, key string, r io.Reader, contentType string) (url string, err error) | ||
| Download(ctx context.Context, key string) (io.ReadCloser, error) | ||
| Exists(ctx context.Context, key string) (bool, error) | ||
| SignedURL(ctx context.Context, key string, ttl time.Duration) (string, error) | ||
| Delete(ctx context.Context, key string) error | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The log message uses
cfg.StorageBackend, which can be empty when the factory defaults to "local" (or when legacy env vars are used). Log the resolved backend (e.g., thebackendchosen insideNewFromConfig, or derive fromstorageBackendtype) so operators see the actual in-use backend.