fix(frontend): download SQLite backup/export in web mode (#688)#703
Open
AtomicTrxn wants to merge 2 commits intoafadil:mainfrom
Open
fix(frontend): download SQLite backup/export in web mode (#688)#703AtomicTrxn wants to merge 2 commits intoafadil:mainfrom
AtomicTrxn wants to merge 2 commits intoafadil:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes self-hosted web backup/export flow for SQLite so users receive a browser download instead of only a server-side filename.
Root cause:
backup_databasealready returned{ filename, data }from backend.useExportDataanduseBackupRestore) ignoreddataand treated result as server-only save.Fix summary:
openFileSaveDialog(data, filename)and treat success as local save.crates/core/src/addons/tests.rs) to satisfy current Rust Check gate.Note: Backend/API unchanged (
POST /utilities/database/backupalready returns data and filename).Test Evidence
cargo fmt --all -- --check✅pnpm --filter frontend test -- use-export-data✅pnpm --filter frontend test -- use-backup-restore✅pnpm run build:types && pnpm --filter frontend type-check✅Fixes #688
Checklist
By submitting this PR, I agree to the CLA.