fix(core): resolve new market equity metadata on save/import (#697)#732
Open
AtomicTrxn wants to merge 3 commits intoafadil:mainfrom
Open
fix(core): resolve new market equity metadata on save/import (#697)#732AtomicTrxn wants to merge 3 commits intoafadil:mainfrom
AtomicTrxn wants to merge 3 commits intoafadil:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary
Root cause
activities_servicevalidated new market equities before live symbol enrichment in manual save and import-apply flows. That meant ticker-only equities likeDPZorHDcould pass import check but still fail on save/apply becauseexchange_micandquote_ccywere not yet populated.Fix
Tests
cargo test -p wealthfolio-core activities_servicecargo fmt --all -- --checkcargo clippy --workspace --all-targets --all-features -- -D warningscargo test --workspaceFixes #697
Checklist
Contributor License Agreement.
By submitting this PR, I agree to the
CLA.