Fix metal price lookups for weight-suffixed symbols#736
Open
triantos wants to merge 1 commit intoafadil:mainfrom
Open
Fix metal price lookups for weight-suffixed symbols#736triantos wants to merge 1 commit intoafadil:mainfrom
triantos wants to merge 1 commit intoafadil:mainfrom
Conversation
Strip the weight suffix from metal instrument symbols before passing them to price providers. XAU-500G and XAU-1KG were being sent as-is, causing both Yahoo and Metal Price API lookups to fail with "no providers available". The weight conversion is already handled separately by metal_weight_oz().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
before passing to price providers
metal_weight_oz(), but the suffixed symbolwas being sent to providers as-is, causing lookup failures
Test plan