Fix memory leaks causing UI freeze after extended use#7
Open
afreakk wants to merge 2 commits intowxt-and-manifest-v3from
Open
Fix memory leaks causing UI freeze after extended use#7afreakk wants to merge 2 commits intowxt-and-manifest-v3from
afreakk wants to merge 2 commits intowxt-and-manifest-v3from
Conversation
- Add proper dat.gui controller disposal before removing folders to prevent accumulated onChange listeners from causing slowdown - Replace frameTimes.shift() with circular buffer (Float32Array) to avoid O(n) operations at 60fps - Reuse Uint8Array buffers for audio data instead of allocating new ones each frame to reduce GC pressure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prevent accumulated onChange listeners from causing slowdown
avoid O(n) operations at 60fps
ones each frame to reduce GC pressure