Skip to content

Patch retransfer behavior#803

Merged
agmes4 merged 1 commit intodevelopfrom
patch-retransfer
Apr 22, 2026
Merged

Patch retransfer behavior#803
agmes4 merged 1 commit intodevelopfrom
patch-retransfer

Conversation

@Crasher508
Copy link
Copy Markdown
Member

  • use type2 user id with checksum instead of plain user id for auto assignment
  • flip the amount of user retransfer

@Crasher508 Crasher508 requested a review from agmes4 April 18, 2026 17:41
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.06%. Comparing base (d1255dd) to head (c9392ab).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #803      +/-   ##
===========================================
+ Coverage    87.95%   88.06%   +0.10%     
===========================================
  Files          280      278       -2     
  Lines        17507    17340     -167     
===========================================
- Hits         15398    15270     -128     
+ Misses        2109     2070      -39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread web/blueprints/finance/__init__.py Outdated
Comment thread web/blueprints/finance/__init__.py Outdated
@agmes4
Copy link
Copy Markdown
Member

agmes4 commented Apr 19, 2026

Also probably the check for the amount in BankAccountTransferForm needs to be changed then

@Crasher508 Crasher508 requested a review from agmes4 April 22, 2026 08:24
@agmes4 agmes4 force-pushed the patch-retransfer branch from afd2a4f to 7e41bd9 Compare April 22, 2026 17:42
amount in absolute value
uses type2 user id with checksum
@agmes4 agmes4 force-pushed the patch-retransfer branch from 7e41bd9 to c9392ab Compare April 22, 2026 17:48
Copy link
Copy Markdown
Member

@agmes4 agmes4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@agmes4 agmes4 merged commit c9392ab into develop Apr 22, 2026
6 checks passed
@Crasher508 Crasher508 deleted the patch-retransfer branch April 22, 2026 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants