[#156] Meaningful names for benchmark scenarios#190
Open
NewtonSander wants to merge 9 commits intomainfrom
Open
[#156] Meaningful names for benchmark scenarios#190NewtonSander wants to merge 9 commits intomainfrom
NewtonSander wants to merge 9 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopening #159
#156
To avoid generating merge conflicts on a few open PRs, I won't merge this until some of the larger PRs touching
Scenarioare merged.Introduction
The scenario numbering does not correspond to anything meaningful. Instead, it would be helpful for users if we named them with descriptive names, like "3-layer skull model" and "RealisticSkull"
Changes
Rename scenarios:
Scenario0-> ScenarioSimpleScenario1-> ScenarioFlatSkullScenario2-> ScenarioRealisticSkullScenario2Benchmark7-> ScenarioRealisticSkullCroppedScenario3-> ScenarioUltrasoundPhantomBehavior
How the new behavior is different from the current behavior, how you tested and how the reviewer can test it.
All unit/integration tests and docs should run as usual. I also searched the project to check for any variable names I missed.