Skip to content

Harden worker command execution and structured failures#9

Merged
vamgan merged 1 commit into
mainfrom
fix/p0-worker-command-and-errors
May 11, 2026
Merged

Harden worker command execution and structured failures#9
vamgan merged 1 commit into
mainfrom
fix/p0-worker-command-and-errors

Conversation

@vamgan
Copy link
Copy Markdown
Contributor

@vamgan vamgan commented May 11, 2026

Summary

  • execute command.run tasks with spawn and parsed argv instead of a shell-backed exec path
  • enforce command allowlists against the parsed executable name
  • return HTTP 200 for structured application-level worker failures so adapters can parse ok:false responses
  • add regression coverage for shell metacharacters, quoted args, and structured failure status

Closes #5
Closes #6

Tests

  • npm run typecheck
  • npm test -- --run
  • npm run build

@vamgan vamgan merged commit 69b31b4 into main May 11, 2026
1 check passed
@vamgan vamgan deleted the fix/p0-worker-command-and-errors branch May 11, 2026 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

P0: Return structured ok:false worker failures without transport 500 P0: Harden command.run allowlist against shell injection

1 participant