Skip to content

Potential fix for code scanning alert no. 16: Uncontrolled command line #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
whyseu wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Potential fix for code scanning alert no. 16: Uncontrolled command line #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions web_anp_llmagent_launcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@
from fastapi.templating import Jinja2Templates
from pydantic import BaseModel

# 验证端口号是否合法
def validate_port(port: int) -> bool:
return isinstance(port, int) and 1 <= port <= 65535

# 设置日志目录
user_dir = os.path.dirname(os.path.abspath(__file__))
log_dir = os.path.join(user_dir, "logs")
Expand Down Expand Up @@ -90,6 +94,10 @@ class InstanceInfo(BaseModel):
def start_instance(command: str, instance_id: str, name: Optional[str] = None, port: Optional[int] = None, did: Optional[str] = None, url: Optional[str] = None) -> bool:
# 如果指定了端口，先检查并清理该端口
if port:
# 验证端口号是否合法
if not validate_port(port):
print(f"无效的端口号: {port}")
return False
print(f"检查端口 {port} 是否被占用")
# 尝试终止使用该端口的进程
if not kill_processes_by_port(port):
Expand Down Expand Up @@ -211,6 +219,10 @@ def read_output(instance_id: str, process: subprocess.Popen):
def kill_processes_by_port(port: int) -> bool:
try:
# 查找使用指定端口的进程
# 验证端口号是否合法
if not validate_port(port):
print(f"无效的端口号: {port}")
return True
cmd = ["lsof", "-i", f":{port}"]
result = subprocess.run(cmd, capture_output=True, text=True)

Expand Down