fix: split verify into separate workflow steps for publish#73
Merged
Conversation
🔍 Pull Request Validation Results
Overall: ✅ All checks passed! ⏰ Generated at: |
- Remove prepublishOnly from both packages - Remove test from per-package verify (vitest needs root cwd) - Add explicit type-check, lint, format, test, build steps to publish workflow verify job — each step visible independently
vreshch
force-pushed
the
bugfix/fix-prepublish
branch
from
bb1c836 to
d2813a1
Compare
vreshch
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prepublishOnlyfrom both packages (triggered per-package vitest which fails from subdirectory)testfrom per-packageverifyscript (vitest needs root cwd)Test plan
npm run verifypasses locally (root level)