fix(server): require control data on create#139
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
lan17
changed the title
abhinav-galileo
approved these changes
Mar 20, 2026
Collaborator
abhinav-galileo
left a comment
abhinav-galileo
left a comment
There was a problem hiding this comment.
Approving - but let's address this:
#139 (comment)
galileo-automation
pushed a commit
that referenced
this pull request
Mar 20, 2026
## [2.1.0](ts-sdk-v2.0.0...ts-sdk-v2.1.0) (2026-03-20) ### Features * **examples:** Feat/crewai examples expansion port ([#142](#142)) ([905e83b](905e83b)) ### Bug Fixes * **server:** require control data on create ([#139](#139)) ([3e4935b](3e4935b)), closes [#138](#138) * **server:** separate compose host port overrides from runtime ports ([#137](#137)) ([da05f98](da05f98))
Collaborator
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dataonPUT /api/v1/controlsinstead of allowing name-only shell control creation422and persist nothingBug Explanation
For a create-with-definition flow, the client did:
PUT /api/v1/controlswith justnamePUT /api/v1/controls/{id}/datawith the definition422, the empty shell from step 2 was still in the DBThat is the concrete bug this PR fixes. Invalid create requests were not atomic, so callers could end up with persisted empty
{}controls even though the overall create-with-definition flow had failed.One nuance: the agent association part was caller-flow dependent. The root server-side invariant failure was the persisted shell control after invalid data, and that is what this change removes.
Testing
cd server && uv run pytest tests/test_controls.py tests/test_controls_additional.py tests/test_controls_validation.py tests/test_agents_additional.py tests/test_auth.py tests/test_control_compatibility.py tests/test_error_handling.py tests/test_evaluation_e2e.py tests/test_evaluation_error_handling.py tests/test_init_agent.py tests/test_init_agent_conflict_mode.py tests/test_new_features.py tests/test_policies.py tests/test_policy_integration.py -qmake lintmake typecheckmake sdk-ts-buildmake ui-typecheck(still fails on pre-existing unrelated UI dependency/type issues)Closes #138