fix(desktop): track ui-desktop's lib/ directories — 180 source files were gitignored - #806
Merged
Merged
Conversation
…were gitignored The root .gitignore's global `lib/` pattern (Python build-output hygiene) silently excluded every lib/ directory under ui-desktop from the stage-1 import: src/lib/** (the renderer's core utility layer), scripts/perf/lib/, and src/app/pet-generate/lib/ — 180 files. Local gates all passed because the files existed on disk in the working tree; only a fresh clone exposed the hole (vite: 'Failed to resolve import "./lib/clipboard"'). Adds the ui-desktop exception next to the existing ui-tui one and commits the missing files. Verified by typechecking a pristine `git archive` export of the branch (the gate stage 1 lacked). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The root .gitignore's global
lib/pattern (Python build-output hygiene) silently excluded everylib/directory underui-desktopfrom the stage-1 import:src/lib/**(the renderer's core utility layer),scripts/perf/lib/, andsrc/app/pet-generate/lib/— 180 files.Every local gate passed because the files existed on disk in the working tree; CI only runs pytest, so nothing TS-side caught it. A fresh clone exposed it immediately: vite fails with
Failed to resolve import "./lib/clipboard" from "src/main.tsx".Fix
!ui-desktop/**/lib/exception next to the existing!ui-tui/src/lib/one.Verification
Typechecked a pristine
git archiveexport of this branch (freshnpm ci, no working-tree files to mask gaps): green across all three tsconfigs — the gate the original import lacked.🤖 Generated with Claude Code