fix(sandbox): complete phase 3 violations and policy fixes#59
Merged
Conversation
✅ Deploy Preview for rad-granita-26ed35 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
haowu1234
force-pushed
the
feat/sandbox-fixes
branch
7 times, most recently
from
64e3f3b to
698d0d4
Compare
- allow_env: SecurityGuard accepts exempt_vars, SeatbeltBackend passes it - deny_write: SeatbeltPolicyBuilder.add_deny_write_paths() generates rules - Violation feedback: _detect_violations() + ViolationStore + CLI command - Wire sandbox_mode.py into from_config_section (eliminate dead code) - safe/dev use restrict_file_read=False (allow-all-read + credential deny) - verify: 9 probes including cred_protect, hooks_protect, env_filter - file.write handler aligned with seatbelt (only block .git/hooks not all) - Toolchain auto-detection + Xcode CLT + home dotfiles whitelist Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
haowu1234
force-pushed
the
feat/sandbox-fixes
branch
from
698d0d4 to
b928ef9
Compare
haowu1234
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses 6 issues identified in the sandbox capability review (all except Mother integration):
allow_envfix —SecurityGuard.sanitize_env()now acceptsexempt_varsparameter;elephant sandbox allow env NODE_AUTH_TOKENactually worksdeny_writefix —SeatbeltPolicyBuilder.add_deny_write_paths()generates real(deny file-write* (subpath ...))rules_detect_violations()parses stderr, maps to structured diagnostics likesandbox:denied:write .git/hooks (protected: git hook injection prevention)from_config_section()now callsmode_to_policy()fromsandbox_mode.pyinstead of duplicated inline logicadd_toolchain_paths()auto-detects~/.pyenv,~/.nvm,~/.rustup,~/.cargo, etc.write_cwdprobe adapts to readonly mode; network probe verifies connectivity when allowedTest plan
allow_envexempts NODE_AUTH_TOKEN in sandboxdeny_writeblocks writes to specified pathsmode_to_policy()correctly drives seatbelt options🤖 Generated with Claude Code