fix: wait for daemon readiness after auto-start#141
Closed
joelklabo wants to merge 1 commit intoagentregistry-dev:mainfrom
Closed
fix: wait for daemon readiness after auto-start#141joelklabo wants to merge 1 commit intoagentregistry-dev:mainfrom
joelklabo wants to merge 1 commit intoagentregistry-dev:mainfrom
Conversation
When arctl auto-starts the daemon via docker compose, the API server inside the container may not be ready to accept requests immediately. The previous 3-attempt ping with linear 1s/2s/3s backoff (6s total) was insufficient for slow networks or cold starts. Changes: - Add WaitForReady() to DaemonManager interface - Implement 30-second exponential backoff polling in DefaultDaemonManager - Call WaitForReady() after Start() in PersistentPreRunE - Increase pingWithRetry to 5 attempts with exponential backoff Fixes agentregistry-dev#48 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
EItanya
approved these changes
Feb 12, 2026
|
This pull request has been marked as stale due to no activity in the last 14 days. It will be closed in 3 days unless it is tagged "no stalebot" or other activity occurs. |
|
This pull request has been closed due to inactivity. |
Contributor
|
closing and using #263 instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #48 —
arctl list -A(and other commands) failed with "failed to reach API after 3 attempts" when the daemon was auto-started because the API server wasn't fully ready when the client tried to connect.Change Type
Changelog
Root cause
After
docker compose up -d --waitreturns, the container is "healthy" per Docker's health check, but the API server inside may still be initializing. The previous retry logic (3 attempts, 1s/2s/3s linear backoff = 6 seconds total) was insufficient for slow networks or cold starts.Changes
pkg/types/types.go: AddedWaitForReady()toDaemonManagerinterfacepkg/daemon/daemon.go: ImplementedWaitForReady()— polls/v0/pingwith exponential backoff (500ms → 4s) for up to 30 secondspkg/cli/root.go: Callsdm.WaitForReady()afterdm.Start()so the API is confirmed responsive before creating the clientinternal/client/client.go: IncreasedpingWithRetryfrom 3 to 5 attempts with exponential backoff as a secondary safety netTests
pkg/daemon/daemon_test.go): interface compliance, already-ready, becomes-ready-after-delay, isServerRespondinginternal/client/client_test.go): immediate success, success after failures, all failgo test ./...cleanTest plan
arctl list -Asucceeds without retry errorsarctl list -Awithout the daemon running the command didn't wait for the daemon to be fully ready before returning #48)WaitForReady()returns immediately if daemon is already runninggo test ./...— all pass🤖 Generated with Claude Code