Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions e2e/deploy_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ var agentDeployTargets = []deployTarget{
},
{
name: "kubernetes",
deplArgs: []string{"--provider-id", "kubernetes-default", "--namespace", "default"},
deplArgs: []string{"--provider-id", "kubernetes", "--namespace", "default"},
cleanup: func(t *testing.T, agentName string) {
ctx, cancel := context.WithTimeout(context.Background(), 30*time.Second)
defer cancel()
Expand All @@ -65,7 +65,7 @@ var mcpDeployTargets = []deployTarget{
},
{
name: "kubernetes",
deplArgs: []string{"--provider-id", "kubernetes-default", "--namespace", "default"},
deplArgs: []string{"--provider-id", "kubernetes", "--namespace", "default"},
cleanup: func(t *testing.T, mcpName string) {
ctx, cancel := context.WithTimeout(context.Background(), 30*time.Second)
defer cancel()
Expand Down
2 changes: 1 addition & 1 deletion internal/cli/agent/deploy.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ var DeployCmd = &cobra.Command{
Example:
arctl agent deploy my-agent --version latest
arctl agent deploy my-agent --version 1.2.3
arctl agent deploy my-agent --version latest --provider-id kubernetes-default`,
arctl agent deploy my-agent --version latest --provider-id kubernetes`,
Args: cobra.ExactArgs(1),
RunE: runDeploy,
}
Expand Down
2 changes: 1 addition & 1 deletion internal/registry/api/handlers/v0/deployment_adapters.go
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ func (a *kubernetesDeploymentAdapter) Deploy(ctx context.Context, req *models.De
}
providerID := req.ProviderID
if providerID == "" {
providerID = "kubernetes-default"
providerID = "kubernetes"
}
env := req.Env
if env == nil {
Expand Down
4 changes: 2 additions & 2 deletions internal/registry/api/handlers/v0/providers_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ func TestListProviders_WithData(t *testing.T) {
k8sAdapter := &fakeProviderAdapter{
platform: "kubernetes",
providers: map[string]*models.Provider{
"kubernetes-default": {ID: "kubernetes-default", Name: "Kubernetes Default", Platform: "kubernetes"},
"kubernetes": {ID: "kubernetes", Name: "Kubernetes Default", Platform: "kubernetes"},
},
}
v0.RegisterProvidersEndpoints(api, "/v0", fake, v0.PlatformExtensions{
Expand All @@ -178,7 +178,7 @@ func TestListProviders_WithData(t *testing.T) {
assert.Equal(t, http.StatusOK, w.Code)
assert.Contains(t, w.Body.String(), `"id":"local"`)
assert.Contains(t, w.Body.String(), `"platform":"local"`)
assert.Contains(t, w.Body.String(), `"id":"kubernetes-default"`)
assert.Contains(t, w.Body.String(), `"id":"kubernetes"`)
assert.Contains(t, w.Body.String(), `"platform":"kubernetes"`)
}

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
-- Rename the kubernetes-default provider ID to kubernetes for consistency.

-- Insert the new provider if it doesn't exist yet.
INSERT INTO providers (id, name, platform, config)
VALUES ('kubernetes', 'Kubernetes', 'kubernetes', '{}'::jsonb)
ON CONFLICT (id) DO NOTHING;

-- Migrate any deployments referencing the old ID.
UPDATE deployments
SET provider_id = 'kubernetes'
WHERE provider_id = 'kubernetes-default';

-- Remove the old provider.
DELETE FROM providers WHERE id = 'kubernetes-default';
2 changes: 1 addition & 1 deletion internal/registry/service/registry_service.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ const (
maxServerVersionsPerServer = 10000

localProviderID = "local"
kubernetesProviderID = "kubernetes-default"
kubernetesProviderID = "kubernetes"
platformLocal = "local"
platformKubernetes = "kubernetes"
resourceTypeMCP = "mcp"
Expand Down
Loading