always set the KAGENT_NAMESPACE; add the agent URL to the deployed page#316
Merged
always set the KAGENT_NAMESPACE; add the agent URL to the deployed page#316
Conversation
Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR ensures local/docker agent deployments always have KAGENT_NAMESPACE set, and enhances the /deployed UI page to display (and copy) the local agent endpoint URL.
Changes:
- Default
KAGENT_NAMESPACEto"default"when not provided during agent resolution. - Add local agent endpoint URL display + copy-to-clipboard action on the
/deployedpage for local deployments.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| ui/app/deployed/page.tsx | Adds computed local agent endpoint URL display and copy button in the deployed resources UI. |
| internal/registry/platforms/utils/deployment_adapter_utils.go | Forces a namespace to be set for resolved agents, defaulting to "default" when missing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>
inFocus7
approved these changes
Mar 12, 2026
Collaborator
inFocus7
left a comment
There was a problem hiding this comment.
lgtm.
validated ui change with
make run
go run ./cmd/cli/main.go agent init adk python agent316
go run ./cmd/cli/main.go agent build agent316 --push
go run ./cmd/cli/main.go agent publish agent316 --version 1.0.0
go run ./cmd/cli/main.go agent deploy agent316 --version 1.0.0 --env GOOGLE_API_KEY=test
open http://localhost:12121/deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We must always set the KAGENT_NAMESPACE, even when deploying to docker. This PR also adds the agent URL to the /deployed page in the UI
Change Type
Changelog