Skip to content

fix(skill): enforce explicit user confirmation before CLI promotion - #233

Open
ronit-1404 wants to merge 1 commit into
agentrhq:mainfrom
ronit-1404:pl1
Open

fix(skill): enforce explicit user confirmation before CLI promotion#233
ronit-1404 wants to merge 1 commit into
agentrhq:mainfrom
ronit-1404:pl1

Conversation

@ronit-1404

Copy link
Copy Markdown

fixes: #223

Description

Enforces a strict separation between private iteration and promotion in the webcmd-adapter-author skill.

Previously, instructions like "build a working adapter" were interpreted as implicit permission to promote the CLI into the main repo. This caused unintended repo-level changes (plugin creation, registration, installation) without explicit user approval.

This update:

  • Makes promotion a clearly gated step
  • Requires explicit user confirmation before any repo-level actions
  • Adds a mandatory checkpoint prompt before promotion
  • Clarifies that building/testing in ~/.webcmd/clis/<site>/ fully satisfies adapter creation

This aligns implementation with the intended behavior defined in the skill.

Related issue:
Fixes implicit CLI promotion without explicit user consent

Type of Change

  • 🐛 Bug fix
  • ✨ New feature
  • 🌐 New site adapter
  • 📝 Documentation
  • ♻️ Refactor
  • 🔧 CI / build / tooling

Checklist

  • I ran the checks relevant to this PR
  • I updated tests or docs if needed
  • I included output or screenshots when useful

Adapter Notes

  • Updated generated or lean docs when command discoverability changed
  • Used positional args for the command's primary subject unless a named flag is clearly better
  • Normalized expected adapter failures to CliError subclasses instead of raw Error

Screenshots / Output

N/A (documentation-only change)

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

🟢 No documentation gap found — medium confidence

The automated review found no documentation gap in the supplied changes.

This review is advisory and does not block merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

webcmd-adapter-author skill promotes CLIs to repo plugins without an explicit user confirmation gate

1 participant