fix(skill): enforce explicit user confirmation before CLI promotion - #233
Open
ronit-1404 wants to merge 1 commit into
Open
fix(skill): enforce explicit user confirmation before CLI promotion#233ronit-1404 wants to merge 1 commit into
ronit-1404 wants to merge 1 commit into
Conversation
Contributor
🟢 No documentation gap found — medium confidenceThe automated review found no documentation gap in the supplied changes. This review is advisory and does not block merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #223
Description
Enforces a strict separation between private iteration and promotion in the
webcmd-adapter-authorskill.Previously, instructions like "build a working adapter" were interpreted as implicit permission to promote the CLI into the main repo. This caused unintended repo-level changes (plugin creation, registration, installation) without explicit user approval.
This update:
~/.webcmd/clis/<site>/fully satisfies adapter creationThis aligns implementation with the intended behavior defined in the skill.
Related issue:
Fixes implicit CLI promotion without explicit user consent
Type of Change
Checklist
Adapter Notes
CliErrorsubclasses instead of rawErrorScreenshots / Output
N/A (documentation-only change)