docs: make CLI-promotion confirmation an explicit, hard-to-read-past gate - #234
Open
ayushsingh82 wants to merge 1 commit into
Open
Conversation
…gate The adapter-author skill gated promoting a private CLI into a repo plugin behind "when the user says to promote a CLI" — a soft clause buried inside a longer sentence. Across three separate adapter builds, a general instruction like "build a real, working adapter, this will be run by the user once done" was read as implicit authorization for the entire pipeline (private iteration + promotion + install), with no separate checkpoint asking whether to promote. Promotion writes into the shared repo and is effectively the moment an adapter goes from drafted to shipped, so it needs its own explicit ask. State the rule as a standalone, bolded gate, note that building and verifying under private iteration already satisfies "build a working adapter" on its own, and have the agent state the checkpoint out loud before promoting instead of continuing silently. Mirror the same note at the top of adapter-template.md's promotion section. Fixes agentrhq#223
Author
|
@ngaurav Fixed — this PR turns the soft "when the user says to promote a CLI" clause into an explicit, bolded confirmation gate in SKILL.md's Key Conventions (and mirrors it in adapter-template.md), so a general "build a working adapter" instruction can no longer be read as implicit authorization to promote, closing #223. |
Contributor
🟢 No documentation gap found — medium confidenceThe automated review found no documentation gap in the supplied changes. This review is advisory and does not block merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SKILL.md"Key Conventions" bullet as a standalone, bolded gate: private iteration alone fully satisfies "build a working adapter,"webcmd plugin create/promotion must wait for explicit confirmation, and the agent should state the checkpoint out loud before promoting rather than continuing silently.references/adapter-template.md's promotion section, since that's the other place an agent following the skill lands on the promotion commands.Fixes #223
Test plan
grep -rlcame up empty)npm run typecheckcleannpm test— 385 test files / 4623 passed, 1 skipped (unchanged baseline)