fix(skill): add a site-named fast path to smart-search (#248) - #269
Open
ankitranjan7 wants to merge 1 commit into
Open
fix(skill): add a site-named fast path to smart-search (#248)#269ankitranjan7 wants to merge 1 commit into
ankitranjan7 wants to merge 1 commit into
Conversation
SERP-first ordering was unconditional, so a request that names Hacker News or Reddit burned its budget on blocked search engines before reaching the site-native adapter that actually worked. When the request names a site, discover adapters first and fall back to the cost order only when no adapter covers that site. Discovery stays live via `webcmd list --tag search` — no routing table. Also: zero extracted result URLs is a failed search, a block/challenge page retires that engine, and adapter availability is checked before reporting a site as blocked. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
🟠 Maintainer review suggested — low confidenceThe automated review could not reach a fully supported conclusion. This review is advisory and does not block merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #248
Problem
skills/smart-search/SKILL.mdmade SERP-first ordering unconditional ("Cost order is mandatory", "Do not jump to adapters because one engine blocked"). That is right when the target site is unknown and backwards when the request names the site: a "research X on Hacker News and Reddit" session burned DuckDuckGo, Bing, two Reddit URLs, an HN page and pullpush.io — all blocked — before reaching the two site-native sources that produced every piece of evidence.Change
webcmd list --tag search -f jsonfirst and use the site's adapter; fall back to the cost order only when no adapter covers that site.puppeteer,playwright).Discovery stays live — no routing table and no
references/sources-*lists, per the existing rules and tests.Verification
npx vitest run src/skills.test.ts— 12 passed, including two new assertions pinning the fast path.🤖 Generated with Claude Code