fix(test): update import mock Manager name - #1034
Closed
RerankerGuo wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
CI attribution: all 9 translation/base/image build checks passed. I inspected the raw logs for all 10 failed integration jobs in run #1661; every matrix entry exits during |
Contributor
Author
|
Closing as superseded by current main. The import package test already mocks agentteams-manager in both ps and exec paths. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The hard rename updated
hiclaw-import.shto discover and executeagentteams-manager, but its unit-style Docker mock still returned and strippedhiclaw-manager. As a result, the test no longer reached the mockedhiclawcommand and failed 5 of 6 assertions. Align the mock with the production container name.Verification
bash tests/test-16-import-worker-package-default.sh(6/6 passed; previously 1/6)bash -n tests/test-16-import-worker-package-default.sh install/hiclaw-import.shgit diff --check