feat(controller): expose spec.env through REST API - #1096
Conversation
Signed-off-by: Jay Shen <shenjiecode@gmail.com>
Signed-off-by: Jay Shen <shenjiecode@gmail.com>
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
Hi @shiyiyue1102 👋 Quick context: this follows up on the REST/CLI surface that #690 intentionally deferred — it carries Since this is my first contribution to the repo, branch protection is holding a couple of things up. Could you help with:
The branch has no conflicts with |
Resolve changelog/current.md conflict from the v1.2.0 changelog restructure: keep the new Breaking Changes / What's New structure and place the REST env feature entry under What's New (EN + ZH).
|
Synced this branch with the latest Verification after the merge:
Both passed locally. The PR is mergeable now; the remaining gate is the first-time-contributor workflows, which still need approval and a successful run. 已将最新 合并后已验证:
本地均已通过。PR 目前已可干净合并;剩余门禁是首次贡献者工作流,需要批准并成功运行。 |
Resolve changelog/current.md conflict from agentscope-ai#1103 (Custom model capability overrides): keep both What's New entries.
|
Hi @shiyiyue1102, thanks a lot for syncing the branch and running the local verification — really appreciated! A heads-up: The branch is clean against @shiyiyue1102 您好,非常感谢帮忙同步分支并跑本地验证! 提醒一下:您同步之后 分支现在与 |
Summary
Follow up on the REST/CLI work intentionally deferred by #690.
WorkerSpec.EnvandManagerSpec.Envalready exist in the CRD and are merged into container environments, but the public REST create/update DTOs do not carry them. As a result,agt apply -faccepts manifests containingspec.envand forwards the field to the REST API, where it is currently ignored.This PR:
envthrough Worker and Manager REST create/update requests;env: {};agt apply -fYAML projection regression;The existing system-wins collision policy and controller-to-backend propagation are unchanged.
Verification
go test ./internal/... ./cmd/...make test-integration