fix(controller): preserve model-switch openclaw reasoning across Manager reconcile - #1129
Open
XbaoWu wants to merge 2 commits into
Open
fix(controller): preserve model-switch openclaw reasoning across Manager reconcile#1129XbaoWu wants to merge 2 commits into
XbaoWu wants to merge 2 commits into
Conversation
CoPaw ignored --no-reasoning while OpenClaw set reasoning=false. Persist model-level generate_kwargs on the modern provider store, sync openclaw.json as bridge SoT, and map reasoning:false in the CoPaw bridge.
Controller PutManagerConfig was regenerating openclaw.json with reasoning=true and writing it to the shared Manager workspace, undoing model-switch within seconds. Prefer the live workspace when merging and preserve per-model reasoning; model-switch best-effort pushes openclaw to MinIO. Document that live reasoning wins over CR/env regenerate and that agents/manager push may 403 without Controller ACL.
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1128
Stacked on #1127 (base:
fix/copaw-model-switch-no-reasoning). Related write-path fix: #1126 / #1127.Summary
model-switch(or a direct edit) setopenclaw.jsonmodelreasoning: false, Controller Manager reconcile regenerated config with defaultreasoning: trueand overwrote the shared live workspace / MinIOagents/manager/openclaw.jsonwithin ~1–4s.PutManagerConfig/UpdateManagerGroupAllowFromnow load existing openclaw local-first (live Manager workspace mount), then OSS.mergeModelReasoningpreserves per-modelreasoningfrom the existing config across regenerate (live/hot-update wins over CR /AGENTTEAMS_MODEL_REASONINGdefaults until the workspace is updated again).model-switchbest-effort pushesopenclaw.jsonto MinIOmanager/+agents/manager/(the latter often 403 for Manager credentials; WARN-only — persistence relies on Controller merge from live workspace).Test plan
golang:1.25-bookworm):TestPutManagerConfig_PreservesModelReasoning,TestPutManagerConfig_PrefersLocalReasoningOverStaleOSS,TestUpdateManagerGroupAllowFrom_PrefersLocalConfig(+ existing PutManagerConfig cases)Notes
reasoningwins over the next Controller regenerate. To flip via CR/env alone, re-runmodel-switch(or edit live openclaw) so the workspace matches.agents/manager/; that remains Controller SoT.