You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PATH=/tmp/AgentTeams-pr969-bin:$PATH bash manager/tests/test-delete-worker-script.sh with jq 1.7.1 (10 passed, 0 failed)
git diff --check
Rebase note
Rebased onto current main (6f0c7da) and preserved the upstream remote-Worker lifecycle guidance. The changelog now adds only this PR's entry.
CI note
The refreshed matrix has 18 passing checks and 2 skips. Its only failure is
the known SHARD_A test-06-multi-worker setup case where the Manager never
created bob; the deterministic bob setup is covered independently by #985.
No worker-deletion path from this PR is involved.
@shiyiyue1102 Hi! This PR addresses #967. Just rebased onto current main (was conflicting) — CI is now green (18/18). Adds a safe hiclaw delete worker <name> wrapper that cleans state.json / worker-lifecycle.json / workers-registry.json so Manager stops looping on bad delete commands. Could you take a look when convenient?
A safe Worker deletion wrapper is useful, but the current PR is too broad for the core problem and conflicts with main. It combines the CLI wrapper, structured output, records-only cleanup, multiple state files, and agent-facing behavior in more than 300 added lines. Please rebase and split the minimal valid hiclaw delete worker wrapper from any local-record recovery or cleanup feature. Each path needs focused tests proving that failed deletion never reports success and that records-only cleanup cannot remove live Worker state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hiclaw delete worker <name>with the valid positional CLI syntaxstate.json,worker-lifecycle.json, andworkers-registry.jsonFixes #967.
Verification
bash -n manager/agent/skills/worker-management/scripts/delete-worker.sh manager/tests/test-delete-worker-script.shPATH=/tmp/AgentTeams-pr969-bin:$PATH bash manager/tests/test-delete-worker-script.shwith jq 1.7.1 (10 passed, 0 failed)git diff --checkRebase note
Rebased onto current
main(6f0c7da) and preserved the upstream remote-Worker lifecycle guidance. The changelog now adds only this PR's entry.CI note
The refreshed matrix has 18 passing checks and 2 skips. Its only failure is
the known SHARD_A
test-06-multi-workersetup case where the Manager nevercreated bob; the deterministic bob setup is covered independently by #985.
No worker-deletion path from this PR is involved.
Temporary dependency
78e9385), whose full CI passed all 10 integration matrices.f154dc72passed every build and all 10 integration matrices.