You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@shiyiyue1102 Hi! SHARD_A copaw/hermes failed on this PR's CI. Same pattern as #984 — in the copaw/hermes case the hiclaw-worker-bob session directory does not exist at all and Manager never invoked hiclaw create worker --name bob — Manager only created alice. Failure mode is a test-prompt interpretation flake, not the model-parameter env wiring in this PR.
This PR only changes Helm values + embedded install scripts + controller config to pass custom model context window / max tokens / reasoning / vision env vars. It doesn't touch the Manager agent runtime or worker-create code path. Could you re-run CI or merge if you agree the flake is unrelated?
Passing model context, token, reasoning, and vision overrides through every deployment path has product value, but the current PR is broad and conflicts with main. It also overlaps newer model-vision and QwenPaw work. Please rebase and verify which pieces are still missing, then either narrow this PR to one coherent model-parameter contract or split installer and controller changes if they can land independently. The updated branch should cover Helm, embedded Bash, PowerShell, config parsing, and nil versus explicit-false behavior with focused tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #961.
Tests
bash -n install/hiclaw-install.sh
git diff --check
Go 1.25.0:
go test ./internal/configNot run:
helm template ...because Helm is not installed (helm: command not found).Temporary dependency
78e9385), whose full CI passed all 10 integration matrices.4fc9eaa4passed every build and all 10 integration matrices.