fix(fund): drop broken Coinbase Onramp URL builder#15
Merged
vvillait88 merged 1 commit intomainfrom May 4, 2026
Merged
Conversation
The URL agentscore-pay fund printed for Base + Solana mainnet was broken end-to-end: Coinbase rejected it with "Missing or invalid parameters / appId required" on the legacy URL flow, and once an appId is added, the project's "secure initialization" setting rejects it again unless the request comes from a server-minted sessionToken. Stopgap: drop the auto-onramp link entirely. fund now prints the receive QR + polls balance for every mainnet chain (matching the existing Tempo UX). Users send USDC from any source they prefer — another wallet, a CEX withdrawal, or any third-party fiat onramp that supports the destination chain. Tempo testnet's programmatic mint via tempo_fundAddress is unchanged. Base Sepolia + Solana devnet still use the existing faucet command. Future direction: Stripe Crypto Onramp via a server-minted session endpoint (pending Stripe approval). Same architectural pattern — backend mints sessionToken, CLI opens the hosted URL — applies to both Coinbase Onramp Session Token API and Stripe Crypto Onramp. Changes: - Remove onrampUrl() function from constants.ts - Drop onramp_url field from FundResult + CreateResult - Update CLI descriptions/hints/examples + agent-guide notes - Rewrite README funding section - Update Mintlify pay-cli + mcp/overview docs - Update internal CLAUDE.md - Remove broken onrampUrl tests Test plan: 352/352 vitest pass (was 356/356; 4 tests removed alongside the deleted onrampUrl function); tsc --noEmit clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The URL
agentscore-pay fundprinted for Base + Solana mainnet was broken end-to-end:appIdis added, the project's "secure initialization" setting still rejects it — Coinbase steers integrators toward server-mintedsessionTokens instead.Stopgap
Drop the auto-onramp link entirely.
fundnow prints the receive QR + polls balance for every mainnet chain (matching existing Tempo UX). Users send USDC from any source — another wallet, a CEX withdrawal, or any third-party fiat onramp that supports the destination chain.Tempo testnet's programmatic mint via
tempo_fundAddressis unchanged. Base Sepolia + Solana devnet still use the existingfaucetcommand.Future direction
Stripe Crypto Onramp via a server-minted session endpoint (pending Stripe approval). Same architectural pattern (backend mints
sessionToken, CLI opens the hosted URL) applies to both Coinbase Onramp Session Token API and Stripe Crypto Onramp — one server-side onramp-broker endpoint will support both providers when we reach that.Changes
onrampUrl()function fromconstants.tsonramp_urlfield fromFundResult+CreateResultonrampUrltestsTest plan
onrampUrlfunction)tsc --noEmitcleanbun installproduces no diff (lockfile in sync)🤖 Generated with Claude Code